From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B5F3743D67A for ; Fri, 18 Oct 2019 01:38:41 +0300 (MSK) References: <20191017222805.GA19660@atlas> From: Vladislav Shpilevoy Message-ID: <4c463b9f-8d99-b3eb-09cf-109d651494b5@tarantool.org> Date: Fri, 18 Oct 2019 00:43:46 +0200 MIME-Version: 1.0 In-Reply-To: <20191017222805.GA19660@atlas> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [tarantool-patches] Re: [PATCH 1/1] replication: auto reconnect if password is invalid List-Id: Tarantool development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: tarantool-patches@dev.tarantool.org, tarantool-patches@freelists.org, Kirill Yukhin Kostja, thanks for the review! Kirill, your turn. On 18/10/2019 00:28, Konstantin Osipov wrote: > * Vladislav Shpilevoy [19/10/18 00:13]: >> Before the patch there was a race in replication >> password configuration. It was possible that a replica >> connects to a master with a custom password before >> that password is actually set. The replica treated the >> error as critical and exited. >> >> But in fact it is not critical. Replica even can >> withstand absence of a user and keeps reconnecting. >> Wrong password situation arises from the same problem >> of non atomic configuration and is fixed the same - >> keep reconnect attempts if the password was wrong. >> >> Closes #4550 > > lgtm >