From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp5.mail.ru (smtp5.mail.ru [94.100.179.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 72C024696C3 for ; Thu, 5 Mar 2020 03:14:23 +0300 (MSK) From: Vladislav Shpilevoy Date: Thu, 5 Mar 2020 01:14:19 +0100 Message-Id: <4bfd55d1ec53a21acd83114ea6bef36c6345c038.1583366981.git.v.shpilevoy@tarantool.org> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Tarantool-patches] [PATCH 1/2] box: fail in box_check_config() on bad sql cache size List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: tarantool-patches@dev.tarantool.org, korablev@tarantool.org, imun@tarantool.org It was calling box_check_sql_cache_size() assuming that it throws. But it returns 0/-1. --- src/box/box.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/box/box.cc b/src/box/box.cc index 09dd67ab4..0212f34ad 100644 --- a/src/box/box.cc +++ b/src/box/box.cc @@ -669,7 +669,8 @@ box_check_config() box_check_memtx_memory(cfg_geti64("memtx_memory")); box_check_memtx_min_tuple_size(cfg_geti64("memtx_min_tuple_size")); box_check_vinyl_options(); - box_check_sql_cache_size(cfg_geti("sql_cache_size")); + if (box_check_sql_cache_size(cfg_geti("sql_cache_size")) != 0) + diag_raise(); } /* -- 2.21.1 (Apple Git-122.3)