From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 04D8169CBB9; Wed, 4 Oct 2023 11:58:33 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 04D8169CBB9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1696409913; bh=rBLV5ZsnVjmTb9A/tDjfGGs2PxCoQ2Deyo1AbcLcGr4=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=I1xFO5681tOJXpky3RkdPDPyaCtLf1vWIbQswjNwou8RqNH8Pd2XS/II5aXFiyv1E NVB1P4oiJYJWps8ZIgAwERij8bv946lnkUiqmnWbrdq98h6KUJ4oOVu6hqn+y6FEik gO71nipYThTFzJqMTAT4tx5qVfRcByinR1gcHm5A= Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [95.163.41.90]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8E5395B18EA for ; Wed, 4 Oct 2023 11:58:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8E5395B18EA Received: by smtp53.i.mail.ru with esmtpa (envelope-from ) id 1qnxiA-00H7Uj-22; Wed, 04 Oct 2023 11:58:31 +0300 Content-Type: multipart/alternative; boundary="------------tIxBdtSyC3TKiIcg0RQEnZ2n" Message-ID: <4bee35bb-7b49-4f33-9e8f-0b535c31fdae@tarantool.org> Date: Wed, 4 Oct 2023 11:58:30 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Maxim Kokryashkin References: <1694549020.38036023@f474.i.mail.ru> <410e5a92-cb69-7916-baaf-9a24aa0f998c@tarantool.org> <1695027102.987261187@f487.i.mail.ru> Content-Language: en-US In-Reply-To: <1695027102.987261187@f487.i.mail.ru> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD94A796AF4779ECFCE2FE4B73CD06F0B7CC57781C9F63FAA84182A05F53808504096E5E74FE0E4747862AAAB14FA191F511A627D78B15609F815383A8D68DB6245 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7BCC85671EC7A750CEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637F91103FA893F53AB8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D838FBB8B4498D7E9CA6694DB4536EE043117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC47272755C61AA17BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751FBDFBBEFFF4125B51D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE9647ADFADE5905B1FCB1554B277F7060D8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE3AD0E433DBF1FBFA303F1AB874ED89028C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F79006373568875668442E59EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A551CB539E5A7563D2599EE042355DBF44BEC899279ADCAEFDF87CCE6106E1FC07E67D4AC08A07B9B0DB8A315C1FF4794DBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF006C8286AFD8B3C7EB7E675369E0ADB05C59735E3F648C3F1AD1E9B9DA5EF30D90383D67CF2F9DA8CC231B5D63B17C6BAD0462675C754DC0090735E519DDEE9CA74DFFEFA5DC0E7F02C26D483E81D6BE0DBAE6F56676BC7117BB6831D7356A2DEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojS50qH6HnxT3i6F4O+H7uqA== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A769CB130D58BC20D8BA62AAAB14FA191F5141B07CD4FDF173FBEBA65886582A37BD66FEC6BF5C9C28D98A98C1125256619760D574B6FC815AB872D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v9 1/2] tools: add cli flag to run profile dump parsers X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: Maxim Kokryashkin , tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------tIxBdtSyC3TKiIcg0RQEnZ2n Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 9/18/23 11:51, Maxim Kokryashkin wrote: > Hi! > > Четверг, 14 сентября 2023, 12:22 +03:00 от Sergey Bronnikov > : > Hi, Max > > Thanks for the fixes! > > Two new comments: > > $  ./build/src/luajit -ts sysprof.bin > ./build/src/luajit: ./tools/utils/symtab.lua:107: attempt to > concatenate > local 'magic' (a nil value) > > Works just fine for me. Make sure you are using the right file. $ ./build/src/luajit -ts sysprof.bin $ file sysprof.bin sysprof.bin: empty $ ./build/src/luajit -ts sysprof.bin ./build/src/luajit: ./tools/utils/symtab.lua:107: attempt to concatenate local 'magic' (a nil value) $ > > Please fix. > > > $  ./build/src/luajit -ts mee > ./build/src/luajit: ./tools/utils/bufread.lua:122: fopen, errno: 2 > > > Seems the case is not handled in your code, let's fix it. > > It is not relevant to flags and should be fixed for both the memprof > and the sysprof in a separate ticket with refactoring. I have no objections, what is a number of the ticket? > > On 9/12/23 23:03, Maxim Kokryashkin wrote: > > Hi, Sergey! > > Thanks for the review! > > Fixed all of your comments, except for the one about > > `luacheckrc` and _TARANTOOL. I believe, it should be > > done in a separate patch. > > > > --------------tIxBdtSyC3TKiIcg0RQEnZ2n Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit


On 9/18/23 11:51, Maxim Kokryashkin wrote:
Hi!
 
Четверг, 14 сентября 2023, 12:22 +03:00 от Sergey Bronnikov <sergeyb@tarantool.org>:
 
Hi, Max

Thanks for the fixes!

Two new comments:

$  ./build/src/luajit -ts sysprof.bin
./build/src/luajit: ./tools/utils/symtab.lua:107: attempt to concatenate
local 'magic' (a nil value)
Works just fine for me. Make sure you are using the right file.


$ ./build/src/luajit -ts sysprof.bin
$ file sysprof.bin
sysprof.bin: empty
$ ./build/src/luajit -ts sysprof.bin
./build/src/luajit: ./tools/utils/symtab.lua:107: attempt to concatenate local 'magic' (a nil value)
$


Please fix.


$  ./build/src/luajit -ts mee
./build/src/luajit: ./tools/utils/bufread.lua:122: fopen, errno: 2


Seems the case is not handled in your code, let's fix it.
It is not relevant to flags and should be fixed for both the memprof
and the sysprof in a separate ticket with refactoring.

I have no objections, what is a number of the ticket?



 

On 9/12/23 23:03, Maxim Kokryashkin wrote:
> Hi, Sergey!
> Thanks for the review!
> Fixed all of your comments, except for the one about
> `luacheckrc` and _TARANTOOL. I believe, it should be
> done in a separate patch.
>
<snipped>
 
--------------tIxBdtSyC3TKiIcg0RQEnZ2n--