From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp10.mail.ru (smtp10.mail.ru [94.100.181.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 5010C42EF5C for ; Fri, 26 Jun 2020 13:57:35 +0300 (MSK) References: From: Serge Petrenko Message-ID: <4bde784c-ff6a-a6d9-2faf-c847d752971b@tarantool.org> Date: Fri, 26 Jun 2020 13:57:33 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: 8bit Content-Language: ru Subject: Re: [Tarantool-patches] [PATCH v2 0/2] decNumber utilites for SQL List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chris Sosnin , tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org 24.06.2020 19:53, Chris Sosnin пишет: > Changes in v2: > - Instead of skipping whitespaces, allow FromString to parse > valid beginning of the string and return pointer to the next > character. Thus, we can check for whitespaces ourselves. > This also requires lib/core changes: either pass a pointer > to decimal_from_string and check for '\0' after every use, or > refactor it so it works the same way and introduce something like strtodec. > - Rename decIsWhole -> decIsInt. > > branch: https://github.com/tarantool/decNumber/tree/ksosnin/utilities-for-sql > related issue: https://github.com/tarantool/tarantool/issues/4415 LGTM > > Chris Sosnin (2): > Refactor decNumberFromString > Add IsInt method for checking the fractional part of a number > > decNumber.c | 46 ++++++++++++++++++++++++++++++++++++++-------- > decNumber.h | 27 ++++++++++++++------------- > 2 files changed, 52 insertions(+), 21 deletions(-) > -- Serge Petrenko