From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 62B0B270D4
	for <tarantool-patches@freelists.org>; Fri, 13 Jul 2018 06:26:11 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id gUZ3sb0o6QRn for <tarantool-patches@freelists.org>;
	Fri, 13 Jul 2018 06:26:11 -0400 (EDT)
Received: from smtp62.i.mail.ru (smtp62.i.mail.ru [217.69.128.42])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 1DE7A270B9
	for <tarantool-patches@freelists.org>; Fri, 13 Jul 2018 06:26:11 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH v1 0/2] sql: restrict nullable action
 definitions
References: <cover.1531413184.git.kshcherbatov@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <4b6e3dc7-13be-66a1-086a-ecb48f39a798@tarantool.org>
Date: Fri, 13 Jul 2018 13:26:07 +0300
MIME-Version: 1.0
In-Reply-To: <cover.1531413184.git.kshcherbatov@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org, Kirill Shcherbatov <kshcherbatov@tarantool.org>

Thanks for the patchset! See 1 comments below.

On 12/07/2018 19:34, Kirill Shcherbatov wrote:
> This patch dissallows define multiple "NULL", "NOT NULL"

Typo.

> options per column and fixes silent implicit behavior
> for invalid "NULL PRIMARY KEY" construction.
> 
> Branch: http://github.com/tarantool/tarantool/tree/kshch/gh-3473-on-conflict-defaults-fixes
> Issue: https://github.com/tarantool/tarantool/issues/3473
> 
> Kirill Shcherbatov (2):
>    sql: restrict nullable action definitions
>    sql: fixed possible leak in sqlite3EndTable
> 
>   src/box/alter.cc              |  1 +
>   src/box/field_def.c           |  1 +
>   src/box/field_def.h           |  3 ++-
>   src/box/sql/build.c           | 53 +++++++++++++++++++++++++++++++++++++------
>   src/box/sql/parse.y           |  2 +-
>   test/sql/on-conflict.result   | 13 +++++++++++
>   test/sql/on-conflict.test.lua |  6 +++++
>   7 files changed, 70 insertions(+), 9 deletions(-)
>