From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 334B56ECFB; Tue, 9 Jun 2026 16:55:42 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 334B56ECFB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1781013342; bh=wgly5rGt5dcGg/2oegXv5AH2EoYVD6Cns0VlhNYFrBc=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=h9VLm4ElPI8MI5SkpbZ2+O37Oy8alQYDMT/MtOJvJDPpxigASiN0tjMIdxLTVEM05 dwpvaVJO5HYjul9oFTF7qvawRsby+kqQFT6/scCrR/BxXrXPIS4Tmo3zNDQJXmcPc0 eeRLHcfLOlu5LRCukU7q/IrBrexkJV17h/UhvCsc= Received: from send278.i.mail.ru (send278.i.mail.ru [95.163.59.117]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E9DA46ECFB for ; Tue, 9 Jun 2026 16:55:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E9DA46ECFB Received: by exim-smtp-5bf699dc9d-q9g2g with esmtpa (envelope-from ) id 1wWwvb-00000000JgS-4Bpc; Tue, 09 Jun 2026 16:55:40 +0300 Content-Type: multipart/alternative; boundary="------------Em0bvKq0YuEhtrTDhyCDdi8S" Message-ID: <4b4838ea-4ada-4bf5-8e20-8083133139df@tarantool.org> Date: Tue, 9 Jun 2026 16:55:38 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Sergey Kaplun , Evgeniy Temirgaleev Cc: tarantool-patches@dev.tarantool.org References: <20260608102318.4068317-1-skaplun@tarantool.org> Content-Language: en-US In-Reply-To: <20260608102318.4068317-1-skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9E926CE86FFF978D751C82848A5B6A578E81DC15FBAC9BD03182A05F538085040232EB0314E84FC0C3DE06ABAFEAF6705135E209E1750A998600636CA48AE48DC6C2BE0BE76D801B4 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F9D3BE5B596754B8C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE789066434B85BF7C7EA1F7E6F0F101C67CDEEF6D7F21E0D1D9295C2E9FA3191EE1B59CA4C82EFA6580824412B47A8D1A5ED95C9260E0F8F974ECA74F6E6BABA45117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAE9A1BBD95851C5BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18BDFBBEFFF4125B51D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6753C3A5E0A5AB5B7089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A58A3004338E0CA2435002B1117B3ED6968D51E966FA9E1EC2C89B063BDC7FAC35823CB91A9FED034534781492E4B8EEADA3FB0D9844EF8EC5BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE191716CD42B3DD1D34CAB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D6598F6AD66A96F6C82F76ECBE79880AE15C1170ADE680B83A101B47A3EEF8E7CB5BB35FDDB0D3CA7D63B8341EE9D5BE9A0A78C31196AAD82C704B4FB2A6249AE8CD32B2261F811B79B46536EB022892E5344C41F94D744909CE2512F26BEC029E55448553D2254B8D95CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVfwaKBAd4IJXtqYE1A9842I= X-DA7885C5: EB4689E8A58E5073F255D290C0D534F902BF2E6AFC25E825458BF9601B6B8969541958A510EA4F5E5B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393520AF17B8A65FDE25AD280AA3F44A89E22B467AF9684020B7376F1A9842F8A08EF86D5F70DA33880E41E8EF7A07863ECB274557F927329BE2DDF8182D28ACDB545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] test: fix libfficcall compilation for old GCC X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------Em0bvKq0YuEhtrTDhyCDdi8S Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hello, Sergey, Thanks for the patch! LGTM with a minor comment. Sergey On 6/8/26 13:23, Sergey Kaplun wrote: > On CentOS 7 GCC has no std=c99 by default. This leads to compilation > warnings and errors for ‘for’ loop initial declarations. This patch > fixes that by declaring the variable out of the loop body. > --- > > Branch:https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-fix-tests-old-gcc > CI failure:https://github.com/tarantool/luajit/actions/runs/27124968515/job/80063067169#step:6:10593 > > test/tarantool-tests/ffi-ccall/libfficcall.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/test/tarantool-tests/ffi-ccall/libfficcall.c b/test/tarantool-tests/ffi-ccall/libfficcall.c > index 2145b556..129bc75d 100644 > --- a/test/tarantool-tests/ffi-ccall/libfficcall.c > +++ b/test/tarantool-tests/ffi-ccall/libfficcall.c > @@ -307,7 +307,8 @@ int test_2_large_agg_a16(int x, large_agg_a16 s1, large_agg_a16 s2) > const int *v1 = s1.v; > const int *v2 = s2.v; > int sum = x; > - for (int i = 0; i < lengthof(s1.v); i++) { > + int i = 0; > + for (; i < lengthof(s1.v); i++) { isn't better declaring outside the loop and define in a loop? int i; for (i = 0; i < lengthof(s1.v); i++) { It looks more familiar this way. Feel free to ignore. > sum += v1[i] + v2[i]; > } > return sum; --------------Em0bvKq0YuEhtrTDhyCDdi8S Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hello, Sergey,

Thanks for the patch! LGTM with a minor comment.

Sergey

On 6/8/26 13:23, Sergey Kaplun wrote:
On CentOS 7 GCC has no std=c99 by default. This leads to compilation
warnings and errors for ‘for’ loop initial declarations. This patch
fixes that by declaring the variable out of the loop body.
---

Branch: https://github.com/tarantool/luajit/tree/skaplun/gh-noticket-fix-tests-old-gcc
CI failure: https://github.com/tarantool/luajit/actions/runs/27124968515/job/80063067169#step:6:10593

 test/tarantool-tests/ffi-ccall/libfficcall.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/test/tarantool-tests/ffi-ccall/libfficcall.c b/test/tarantool-tests/ffi-ccall/libfficcall.c
index 2145b556..129bc75d 100644
--- a/test/tarantool-tests/ffi-ccall/libfficcall.c
+++ b/test/tarantool-tests/ffi-ccall/libfficcall.c
@@ -307,7 +307,8 @@ int test_2_large_agg_a16(int x, large_agg_a16 s1, large_agg_a16 s2)
 	const int *v1 = s1.v;
 	const int *v2 = s2.v;
 	int sum = x;
-	for (int i = 0; i < lengthof(s1.v); i++) {
+	int i = 0;
+	for (; i < lengthof(s1.v); i++) {

isn't better declaring outside the loop and define in a loop?

int i;
for (i = 0; i < lengthof(s1.v); i++) {

It looks more familiar this way. Feel free to ignore. 
 		sum += v1[i] + v2[i];
 	}
 	return sum;
--------------Em0bvKq0YuEhtrTDhyCDdi8S--