From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id E205D251DA for ; Sat, 20 Jul 2019 10:01:17 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o_Zp63-LTa_T for ; Sat, 20 Jul 2019 10:01:17 -0400 (EDT) Received: from smtp63.i.mail.ru (smtp63.i.mail.ru [217.69.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 27101251A9 for ; Sat, 20 Jul 2019 10:01:17 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH 2/2] sql: transactional DDL References: <5863bb4286a3e45b3521420273d89347bd331a92.1563576462.git.v.shpilevoy@tarantool.org> <20190720074210.GA27751@atlas> From: Vladislav Shpilevoy Message-ID: <4a273360-5db0-7b3a-1094-d28e18688139@tarantool.org> Date: Sat, 20 Jul 2019 16:02:59 +0200 MIME-Version: 1.0 In-Reply-To: <20190720074210.GA27751@atlas> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org, Konstantin Osipov Cc: korablev@tarantool.org On 20/07/2019 09:42, Konstantin Osipov wrote: > * Vladislav Shpilevoy [19/07/20 01:52]: >> index 000000000..8f7f91151 >> --- /dev/null >> +++ b/test/sql/ddl.result >> @@ -0,0 +1,356 @@ >> +-- test-run result file version 2 >> +test_run = require('test_run').new() >> + | --- >> + | ... >> +engine = test_run:get_cfg('engine') >> + | --- > > Just curious why did you choose Lua test format and not SQL? > > Now that SQL format is in place my personal preference would be is > that it is used for SQL tests whenever possible, to improve > readability (SQL syntax highlighting, autocompletion). > > What do you miss in SQL tests format? > > I personally only miss anonymous sql/psm blocks and loops. > > Firstly, Lua tests still are easier to copy paste into console as is. Secondly, I just used to write Lua tests. Thirdly, I don't like tap tests, because you need compare results manually instead of just printing them.