From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 514A422044
	for <tarantool-patches@freelists.org>; Tue, 26 Jun 2018 12:21:05 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 8hXHU3qzGZzn for <tarantool-patches@freelists.org>;
	Tue, 26 Jun 2018 12:21:05 -0400 (EDT)
Received: from smtp17.mail.ru (smtp17.mail.ru [94.100.176.154])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id EFB9421CFA
	for <tarantool-patches@freelists.org>; Tue, 26 Jun 2018 12:21:04 -0400 (EDT)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: [tarantool-patches] Re: [PATCH] sql: export `sql_current_time` &&
 enable tests
From: "n.pettik" <korablev@tarantool.org>
In-Reply-To: <20180516133341.21434-1-avkhatskevich@tarantool.org>
Date: Tue, 26 Jun 2018 19:21:01 +0300
Content-Transfer-Encoding: 7bit
Message-Id: <4AD7FCD7-67EB-4B16-BC6A-641FAE19E17E@tarantool.org>
References: <20180516133341.21434-1-avkhatskevich@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: Alex Khatskevich <avkhatskevich@tarantool.org>


> -- Test cases table-14.*
> --
> @@ -970,26 +944,6 @@ end
> -- But DROP TABLE is still prohibited because we do not want to
> -- delete a table out from under a running query.
> --
> --- db eval {
> ---   pragma vdbe_trace = 0;
> --- }
> --- Try to create a table from within a callback:
> --- ["unset","-nocomplain","result"]
> -test:do_test(
> -    "table-14.1",
> -    function()
> -        local rc = pcall(function()
> -            test:execsql("SELECT * FROM tablet8 LIMIT 1")
> -            test:execsql("CREATE TABLE t9(a primary key, b, c)")
> -            end)
> -        rc = rc == true and 0 or 1
> -        return { rc }
> -    end, {
> -        -- <table-14.1>
> -        0
> -        -- </table-14.1>
> -    })
> -

Idk why did you delete this test within current patch?

The rest seems to be OK.