From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 559C72BF83
	for <tarantool-patches@freelists.org>; Sun,  5 May 2019 07:31:35 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id eqV20U1xA5Vr for <tarantool-patches@freelists.org>;
	Sun,  5 May 2019 07:31:35 -0400 (EDT)
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 913E52BF3B
	for <tarantool-patches@freelists.org>; Sun,  5 May 2019 07:31:34 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH v1 2/3] sql: rework diag_set() in OP_Halt
References: <cover.1555072183.git.imeevma@gmail.com>
 <79e3d0e51a64bf35cf5b505d2541996f60b02b8c.1555072183.git.imeevma@gmail.com>
 <28C698E1-979F-4148-942E-38DCAE4AE0DD@tarantool.org>
 <20190426074808.GC23413@tarantool.org>
 <353E4E8B-DA71-4F64-8A61-4E89151E7B5B@tarantool.org>
From: Imeev Mergen <imeevma@tarantool.org>
Message-ID: <4939f7b5-5923-13f7-a030-9fc83f1017d8@tarantool.org>
Date: Sun, 5 May 2019 14:31:32 +0300
MIME-Version: 1.0
In-Reply-To: <353E4E8B-DA71-4F64-8A61-4E89151E7B5B@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-Help: <mailto:ecartis@freelists.org?Subject=help>
List-Unsubscribe: <mailto:tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-Subscribe: <mailto:tarantool-patches-request@freelists.org?Subject=subscribe>
List-Owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-Archive: <http://www.freelists.org/archives/tarantool-patches>
To: "n.pettik" <korablev@tarantool.org>, tarantool-patches@freelists.org


On 4/29/19 2:35 AM, n.pettik wrote:
>
>> On 26 Apr 2019, at 10:48, Mergen Imeev <imeevma@tarantool.org> wrote:
>> New patch:
>>
>>  From 4c1ad4e67773232168f13b0d501f4476673b57c6 Mon Sep 17 00:00:00 2001
>> Date: Fri, 12 Apr 2019 14:16:18 +0300
>> Subject: [PATCH] sql: rework diag_set() in OP_Halt
>>
>> Prior to this patch, the way to set Tarantool error in OP_Halt was
>> too universal. It was possible to set a description of the error
>> that does not match its errcode. This change will also make it
>> easier to work with an error in OP_Halt, since you no longer need
>> to create a complete error message.
> Please, inline exactly the same example as you shown
> in previous mail.
I do not think that one example will be useful now, since we
replaced ER_SQL with ER_SQL_EXECUTE in previous patches. I am
going to include this one:
...

tarantool> box.execute('select 1 limit true')
---
- error: Only positive integers are allowed in the LIMIT clause
...

tarantool> box.error.last().code
---
- 0
...