From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 0A3FB6EC40; Wed, 18 Aug 2021 19:55:14 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0A3FB6EC40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1629305714; bh=V9rtcJ672xseFKmfK+2OtMCUYf0fLzNL2s6JCBVG/1o=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=YI3P6WOSNAtDJcna6jbNwmXoJfqKUrbVDMQhoKPuUOoArkZaIjLdSGkozapcSuGni +dQSzU5XZIfHI6pmFzdZ9bIm2fLspLH2qkvcGF3F4shLU3NcaT+/ojEDIItggVA8Ld TEwrC+nuGIsq6RMvFREpdtKleQSExy5hMN/rwBLg= Received: from smtp29.i.mail.ru (smtp29.i.mail.ru [94.100.177.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 19D9E6EC40 for ; Wed, 18 Aug 2021 19:55:12 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 19D9E6EC40 Received: by smtp29.i.mail.ru with esmtpa (envelope-from ) id 1mGOqN-0001qf-1X; Wed, 18 Aug 2021 19:55:11 +0300 To: imeevma@tarantool.org, korablev@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: <175c9ed1210c35b9e51d89bf9abcdd2c0f941638.1629129129.git.imeevma@gmail.com> Message-ID: <49288cc9-498e-d447-15a6-3e8fbf18e8d3@tarantool.org> Date: Wed, 18 Aug 2021 19:54:58 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <175c9ed1210c35b9e51d89bf9abcdd2c0f941638.1629129129.git.imeevma@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92087353F0EC44DD91BCCB18F2C129F87F36E61E9E4584E9D182A05F538085040AC5681380974D17FF936150AB3B559AC8D6F34154B4EFBBDACE93DD33B14FD3B X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7BF6702EC5472AA0FEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637C21C2889FA5309238638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8D424E6B435EB562C80A8C89DBF05D503117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC2EE5AD8F952D28FBA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18CB629EEF1311BF91D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE7B96B19DC40933211C9461EB66F04EBFD8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE3632EDEA9CD5989A32D242C3BD2E3F4C6C4224003CC836476EA7A3FFF5B025636E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637FB177F6A8366F17BEFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458F0AFF96BAACF4158235E5A14AD4A4A4625E192CAD1D9E79D0B18DC6AC13D9A1C488D83111EEFC2A5 X-C1DE0DAB: 0D63561A33F958A5F9581F839B829369FFE31E4E50E42ACB60CFD7C4F18AE52BD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA75C29D03FC76C37677410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34FA5A4D623E7343BB766A77A73B9F4173D9A9EF0AF1CB68DECD65B8418734C64A0F2E075C398D1D061D7E09C32AA3244C85CDFE25ECE9FD3BE2A75E2333BB82D930452B15D76AEC14FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojGSxK+6r6oBHD/6D+LjD6Iw== X-Mailru-Sender: 6CA451E36783D721CBEA96CEA26D325D2C66088E3035A4CB8E6B8E5CFFE1F576B7CBEF92542CD7C82F97C478340294DCC77752E0C033A69E0F0C7111264B8915FF1320A92A5534336C18EFA0BB12DBB0 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 1/4] decimal: introduce decimal_is_neg() X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Safin Timur via Tarantool-patches Reply-To: Safin Timur Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" LGTM, though... On 16.08.2021 18:57, Mergen Imeev via Tarantool-patches wrote: > This patch introduces function decimal_is_neg() which checks that > decimal is less than zero. > > Needed for #4415 > --- > src/lib/core/decimal.c | 6 ++++++ > src/lib/core/decimal.h | 4 ++++ > test/unit/decimal.c | 7 ++++++- > test/unit/decimal.result | 10 +++++++++- > 4 files changed, 25 insertions(+), 2 deletions(-) > > diff --git a/src/lib/core/decimal.c b/src/lib/core/decimal.c > index 6d2ccb96f..7543ef44d 100644 > --- a/src/lib/core/decimal.c > +++ b/src/lib/core/decimal.c > @@ -115,6 +115,12 @@ decimal_is_int(decimal_t *dec) > return decNumberIsInt(dec); > } > > +bool > +decimal_is_neg(const decimal_t *dec) > +{ > + return decNumberIsNegative(dec) && !decNumberIsZero(dec); > +} > + ^^ here was a good place for decimal_to_string() > decimal_t * > decimal_from_string(decimal_t *dec, const char *str) > { > diff --git a/src/lib/core/decimal.h b/src/lib/core/decimal.h > index aeafd2c68..15a576648 100644 > --- a/src/lib/core/decimal.h > +++ b/src/lib/core/decimal.h > @@ -81,6 +81,10 @@ decimal_zero(decimal_t *dec); > bool > decimal_is_int(decimal_t *dec); > > +/** @return true if the decimal is negative, false otherwise. */ > +bool > +decimal_is_neg(const decimal_t *dec); > + > /** > * Initialize a decimal with a value from the string. > * > diff --git a/test/unit/decimal.c b/test/unit/decimal.c > index aea646e15..328b1b668 100644 > --- a/test/unit/decimal.c > +++ b/test/unit/decimal.c > @@ -336,7 +336,7 @@ test_mp_print(void) > int > main(void) > { > - plan(304); > + plan(312); > > dectest(314, 271, uint64, uint64_t); > dectest(65535, 23456, uint64, uint64_t); > @@ -416,5 +416,10 @@ main(void) > dectest_is(is_int, 1.0000, true); > dectest_is(is_int, 1.0000001, false); > > + dectest_is(is_neg, 1, false); > + dectest_is(is_neg, -1, true); > + dectest_is(is_neg, 0, false); > + dectest_is(is_neg, -0, false); > + > return check_plan(); > } > diff --git a/test/unit/decimal.result b/test/unit/decimal.result > index b7da2d2ce..ceaaf718a 100644 > --- a/test/unit/decimal.result > +++ b/test/unit/decimal.result > @@ -1,4 +1,4 @@ > -1..304 > +1..312 > ok 1 - decimal(314) > ok 2 - decimal(271) > ok 3 - decimal(314) + decimal(271) > @@ -747,3 +747,11 @@ ok 301 - decimal_from_string(1.0000) > ok 302 - decimal_is_int(1.0000) - expected true > ok 303 - decimal_from_string(1.0000001) > ok 304 - decimal_is_int(1.0000001) - expected false > +ok 305 - decimal_from_string(1) > +ok 306 - decimal_is_neg(1) - expected false > +ok 307 - decimal_from_string(-1) > +ok 308 - decimal_is_neg(-1) - expected true > +ok 309 - decimal_from_string(0) > +ok 310 - decimal_is_neg(0) - expected false > +ok 311 - decimal_from_string(-0) > +ok 312 - decimal_is_neg(-0) - expected false >