From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 05E1D2AE1D for ; Mon, 3 Jun 2019 04:04:41 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9kXtnvt3HISv for ; Mon, 3 Jun 2019 04:04:40 -0400 (EDT) Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [94.100.177.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 4F45929DE2 for ; Mon, 3 Jun 2019 04:04:40 -0400 (EDT) From: =?utf-8?B?0JPQtdC+0YDQs9C40Lkg0JrQuNGA0LjRh9C10L3QutC+?= Subject: [tarantool-patches] Re: [PATCH v2 6/8] Offload tx_prio processing to a fiber Date: Mon, 03 Jun 2019 11:04:12 +0300 Message-ID: <4925524.u2yoS9hEEQ@home.lan> In-Reply-To: <20190531193610.GE6141@atlas> References: <7ea0167cb98532c99905f74be0c07a95ead02d04.1558598679.git.georgy@tarantool.org> <20190531193610.GE6141@atlas> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart7125515.xZJdtYQods"; micalg="pgp-sha256"; protocol="application/pgp-signature" Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Konstantin Osipov --nextPart7125515.xZJdtYQods Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" On Friday, May 31, 2019 10:36:10 PM MSK Konstantin Osipov wrote: > * Georgy Kirichenko [19/05/23 11:48]: > > I appreciate you don't use a fiber_call() or fiber_wakeup() > right from the callback, > > In other places we actually use fiber_wakeup(). Please see gc.c, > memtx_engine.c and others. It isn't possible because this fiber could process some yielding activity (ddl). > > So please let's not use has_message/cond, simply wakeup the fiber > in question. > > More comments as to why you need to run these in a fiber would not > harm. --nextPart7125515.xZJdtYQods Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEFB+nbqWGnp59Rk9ZFSyY70x8X3sFAlz01HwACgkQFSyY70x8 X3uHIgf+Mq8s8NJCuyrbXAANP2Z2UO7FRfMG8p+MbMF3ZFDnXRbbzj7mpCmZpT5q 9N8UHkC3no6nySQrYvo8knSyULvtT6G1J24b77CUkvr9ptIgZWwTgAZdqyJlEvLJ 0Uqz+HFG64UsUlcpbP2M+EOHraY+Kmq7lkl9UTa3N0CJ3e5yxz0AwO7JJT6clvPj smrLr7aFf1b0KtDzKYKseWt6MLTxqiDbLc1JavSbnxPwXRTX2wykllAjoOOSl3Fs KgW63pcDC/y0xsVia4sbK4pJn2ccnO8iNszg7RNS+K2G3haFYoP3vOy5jS0aSg/c KSq5hxdtudkx6/I0/HS6IyFwkVV0Aw== =LJoT -----END PGP SIGNATURE----- --nextPart7125515.xZJdtYQods--