From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 5B0F46F839F; Wed, 22 Nov 2023 18:30:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 5B0F46F839F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1700667031; bh=QT0/U2rHyBiHYV+jpqasCpRP3zO0PgbXicY3a3Frp+c=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=iJB+8LGkxTrMkI6Dqnt56n2CALVKDvyJ/i8xNpvnPsh6povEUbSluMLU8npl49xZh KsqXhsIIuswgdlp/sA0qSKV7NhK9O3mDIKkC2DH2tXEy81YUpi7+CH7cuB8qfZZ+B9 snv/NJVNGykmMuhyXwXs7mm6wpul5N5EjzUZE/7g= Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [95.163.41.99]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 360F66F839F for ; Wed, 22 Nov 2023 18:30:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 360F66F839F Received: by smtp61.i.mail.ru with esmtpa (envelope-from ) id 1r5pBL-000VZl-35; Wed, 22 Nov 2023 18:30:28 +0300 Content-Type: multipart/alternative; boundary="------------ClEZEOPysMSxB2ahVHFrspXT" Message-ID: <491ebdf8-10f1-4d5e-8059-855f0bf73e4e@tarantool.org> Date: Wed, 22 Nov 2023 18:30:27 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Maksim Kokryashkin , m.kokryashkin@tarantool.org References: <20231109134549.4905-1-max.kokryashkin@gmail.com> <1e374d3c-ad4a-4379-a22b-85cbc083f658@tarantool.org> In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9FEA8E122FE2215F5F9A7F26A9461D4801668790ACF3513421867C24CE74E72BB5FE18E9CBFBE7C070FE4BD5BDF2273D84220808B3C6959E2C2F799BF13C7D916F8D9167951636718 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7D3DF794D859AA4BFEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375E347E1311495C1B8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8A71F0E932E4CD1F7BF0EB53750654C75117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAE9A1BBD95851C5BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751FC26CFBAC0749D213D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE9647ADFADE5905B17F16001415B11694D8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE34E7D9683544204AF040F9FF01DFDA4A8C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB861051D4BA689FC2E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89F890A246B268E114EC6EABA9B74D0DA47B5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A543E5E03700517A74C1E8A3A50B996F560540E98F460C1F68F87CCE6106E1FC07E67D4AC08A07B9B01DAA61796BF5227BCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34806D3522FB05EB3971A0FAE6957CD8D728E0A12A213E61018C2577F1D247C58798BCAED9339584991D7E09C32AA3244CCE6C1D02B9C8E7D21B597009A65E16DD05AB220A9D022EBCED9A463B7D0AAFF65DA084F8E80FEBD3FFA33E6B6B2F82C47A83BD0C44CE203720ABEDE4BBDD9CDD X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojGZhPsaRkbbl4L7AsnMIrZg== X-Mailru-Sender: 11C2EC085EDE56FAC07928AF2646A769F1E4F1FB1DDD229AED2155D89149530F60497F7EF99AAC8FEBA65886582A37BD66FEC6BF5C9C28D98A98C1125256619760D574B6FC815AB872D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v2] test: fix flaky OOM error frame test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------ClEZEOPysMSxB2ahVHFrspXT Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Max, I would put this text to a comment for clarity. Feel free to ignore. On 11/20/23 17:53, Igor Munkin wrote: > The reason of two consequent calls is not for "mark and > sweep" but rather for "full GC cycle + finalization of the resurrected > objects". The first call implements full (even 1.5) GC cycle; as a > result of this call some *objects* can be *released*, but the > corresponding *memory* is preserved in another list (gc->mmudata, IIRC) > to properly finalize the object (i.e. call __gc metamethod). Hence, the > second call finally releases the memory for the objects resurrected > within the sweep phase of the first call. > > Since Max allocates plain FFI objects with no finalizers, > there is no need in the second call here. > --------------ClEZEOPysMSxB2ahVHFrspXT Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Max,

I would put this text to a comment for clarity.

Feel free to ignore.

On 11/20/23 17:53, Igor Munkin wrote:

<snipped>
The reason of two consequent <collectgarbage> calls is not for "mark and
sweep" but rather for "full GC cycle + finalization of the resurrected
objects". The first call implements full (even 1.5) GC cycle; as a
result of this call some *objects* can be *released*, but the
corresponding *memory* is preserved in another list (gc->mmudata, IIRC)
to properly finalize the object (i.e. call __gc metamethod). Hence, the
second call finally releases the memory for the objects resurrected
within the sweep phase of the first call.

Since Max allocates plain FFI objects with no <ffi.gc> finalizers,
there is no need in the second <collectgarbage> call here.
<snipped>
--------------ClEZEOPysMSxB2ahVHFrspXT--