From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olegrok@tarantool.org>
Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [94.100.177.94])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 201324696C3
 for <tarantool-patches@dev.tarantool.org>;
 Fri,  1 May 2020 19:59:15 +0300 (MSK)
From: Oleg Babin <olegrok@tarantool.org>
References: <cover.1588292014.git.v.shpilevoy@tarantool.org>
 <3a29de4882b343fbff17058f67ec59867ec25e4a.1588292014.git.v.shpilevoy@tarantool.org>
Message-ID: <490a72ce-8803-a3bb-6c80-46fcbf3f1165@tarantool.org>
Date: Fri, 1 May 2020 19:59:13 +0300
MIME-Version: 1.0
In-Reply-To: <3a29de4882b343fbff17058f67ec59867ec25e4a.1588292014.git.v.shpilevoy@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH vshard 2/7] router: introduce
	discovery_mode
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, tarantool-patches@dev.tarantool.org

Thanks for the patch! LGTM.

On 01/05/2020 03:16, Vladislav Shpilevoy wrote:
> Discovery disabling may be useful when there are very many routers
> and buckets, and a user does not want to pay overhead of the
> automatic massive discovery. It may be expensive in big clusters.
> 
> In that case users may want to turn off discovery when there is
> no rebalancing, and turn it back on, when it starts, to keep the
> routers up to date with _bucket changes.
> 
> Part of #210