From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 9CCCB26FDB
	for <tarantool-patches@freelists.org>; Tue,  3 Jul 2018 10:02:49 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id mCvcfbjGsBfL for <tarantool-patches@freelists.org>;
	Tue,  3 Jul 2018 10:02:49 -0400 (EDT)
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 0F82926FA4
	for <tarantool-patches@freelists.org>; Tue,  3 Jul 2018 10:02:48 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: show formated MsgPack
 BLOB on select
References: <3778fd7451fde6e28b3b4c9fcf88fb310a8b50b6.1530534766.git.kshcherbatov@tarantool.org>
 <625D5EC7-6D4C-4D9A-9115-DB88773D5979@tarantool.org>
 <50e6e53a-ed40-f051-a236-2b528d8f9d2b@tarantool.org>
 <1ECACBA2-8B87-416B-9C9D-DF4A0FE4FA03@tarantool.org>
 <9fe4782c-0824-095a-508f-8721282aa24c@tarantool.org>
 <397d7f5b-3a1e-18e8-128e-cc006c3ae5cb@tarantool.org>
From: Kirill Shcherbatov <kshcherbatov@tarantool.org>
Message-ID: <489910bc-cb18-b014-d034-7004b9135b44@tarantool.org>
Date: Tue, 3 Jul 2018 17:02:46 +0300
MIME-Version: 1.0
In-Reply-To: <397d7f5b-3a1e-18e8-128e-cc006c3ae5cb@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org, Nikita Pettik <korablev@tarantool.org>
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>

> Hello. Thanks for the patch! I have pushed my fixes on the
> branch in a separate commit. Please, look and squash if you
> are ok with it.
Tnx. Ok for me, excluding this:

+++ b/src/box/sql/vdbeapi.c
@@ -224,8 +224,7 @@ sqlite3_value_int64(sqlite3_value * pVal)
enum sql_subtype
sqlite3_value_subtype(sqlite3_value * pVal)
{
- Mem *pMem = (Mem *) pVal;
- return (pMem->flags & MEM_Subtype) != 0 ? pMem->subtype : 0;
+ return (pVal->flags & MEM_Subtype) != 0 ? pVal->subtype : SQL_SUBTYPE_NO;
}

on head "review review fixes"

> Nikita, please, look at my changes too, they are not minor.