From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 0F121DD9AB5; Thu, 19 Sep 2024 21:53:55 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0F121DD9AB5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1726772035; bh=ki0e/6bbrY5wyqjPz9XuVoImAEpgdilq2Kx4J3mRmcY=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=dEFrAK3zhhr0DesnLmZIO/8wvz8wVqMek7F0E9SjSR6U+hFmlX6iQHXMPE3WDgkWe uH9l6DFaBgCI+i6pxbsqhie73OqI4mNbkQTK9IQ7ruvPKCx0MhyT+7K9nCLWuFFO/5 6PUhuxxiGAVOpMLChOm/vKkYwZLxxH5EdTPHmuFU= Received: from smtp32.i.mail.ru (smtp32.i.mail.ru [95.163.41.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A6A14DD9A90 for ; Thu, 19 Sep 2024 21:53:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A6A14DD9A90 Received: by smtp32.i.mail.ru with esmtpa (envelope-from ) id 1srMHo-0000000Fmqw-46ia; Thu, 19 Sep 2024 21:53:53 +0300 Content-Type: multipart/alternative; boundary="------------i8K0um0abyhzxmjcutvmN9XM" Message-ID: <4838e045-67a0-48ce-b7e9-1e77a6a94a44@tarantool.org> Date: Thu, 19 Sep 2024 21:53:52 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun , Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org References: <20240902125421.16727-1-skaplun@tarantool.org> <20240919111947.12653-1-skaplun@tarantool.org> In-Reply-To: <20240919111947.12653-1-skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD96E52E9D942F25A5FD82F0D35723335F8AA74852F2FFDBBE200894C459B0CD1B9B27F5C48020A1291A023861817A3C3F86B95181759A6FEA6E983C01E6899CA9C4F193C0F926A29E4 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE721B3E54BB37EA0B4EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637770CCD3A0ADFB7EEEA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38B043BF0FB74779F3622929D4B94D3714342EB50D3549D16106A5BC5C381C61853A471835C12D1D9774AD6D5ED66289B5259CC434672EE6371117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE70F3DDF2BBF19B93A9FA2833FD35BB23DF004C90652538430302FCEF25BFAB3454AD6D5ED66289B5278DA827A17800CE7335A7DDF7B73F052D32BA5DBAC0009BE395957E7521B51C2330BD67F2E7D9AF1090A508E0FED6299176DF2183F8FC7C085416D4FD21775FECD04E86FAF290E2DB606B96278B59C421DD303D21008E29813377AFFFEAFD269176DF2183F8FC7C0D75EB778CE7D8A0C68655334FD4449CB33AC447995A7AD1857739F23D657EF2BD5E8D9A59859A8B67E7DE1D7AD2EB326089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A576D8364BEC5DEDA25002B1117B3ED6961B908A542D6C2E5C250A03108B67251B823CB91A9FED034534781492E4B8EEADB1D70E2111C441FFBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFE448EBFA057DA668EF9165C83DFD77538AF2EA6DDADAF537E1AC7A9C616A8FCA6E5D3BE3824D6F34037F1EA6941D4E95EE36D5342095E60F013E62C1C57A53E3AB8B0364FABD8A205F4332CA8FE04980913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojdLGO8aq4B0Nlpy0VXEOTFQ== X-Mailru-Sender: C4F68CFF4024C8867DFDF7C7F2588458EE2FD8FF3A24D6A88BD48BD36611AD34B52CF7CF5AF94BDCA4C9990687E98602645D15D82EE4B272BD6E4642A116CA93524AA66B5ACBE6721EF430B9A63E2A504198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] Drop unused function wrapper. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------i8K0um0abyhzxmjcutvmN9XM Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey thanks for the patch! LGTM On 19.09.2024 14:19, Sergey Kaplun wrote: > From: Mike Pall > > (cherry picked from commit 87ae18af97fd4de790bb6c476b212e047689cc93) > > This patch is a follow-up to the previous commit. Since the rehashing of > the finalizer table is gone, `lj_tab_rehash()` becomes unused and can be > dropped. > > Sergey Kaplun: > * added the description for the patch > > Part of tarantool/tarantool#10199 > Follows up tarantool/tarantool#10290 > --- > src/lj_tab.c | 7 ------- > src/lj_tab.h | 3 --- > 2 files changed, 10 deletions(-) > > diff --git a/src/lj_tab.c b/src/lj_tab.c > index 1d6a4b7f..c99c6521 100644 > --- a/src/lj_tab.c > +++ b/src/lj_tab.c > @@ -388,13 +388,6 @@ static void rehashtab(lua_State *L, GCtab *t, cTValue *ek) > lj_tab_resize(L, t, asize, hsize2hbits(total)); > } > > -#if LJ_HASFFI > -void lj_tab_rehash(lua_State *L, GCtab *t) > -{ > - rehashtab(L, t, niltv(L)); > -} > -#endif > - > void lj_tab_reasize(lua_State *L, GCtab *t, uint32_t nasize) > { > lj_tab_resize(L, t, nasize+1, t->hmask > 0 ? lj_fls(t->hmask)+1 : 0); > diff --git a/src/lj_tab.h b/src/lj_tab.h > index 71e34945..8575e7bd 100644 > --- a/src/lj_tab.h > +++ b/src/lj_tab.h > @@ -41,9 +41,6 @@ LJ_FUNC GCtab * LJ_FASTCALL lj_tab_new1(lua_State *L, uint32_t ahsize); > LJ_FUNCA GCtab * LJ_FASTCALL lj_tab_dup(lua_State *L, const GCtab *kt); > LJ_FUNC void LJ_FASTCALL lj_tab_clear(GCtab *t); > LJ_FUNC void LJ_FASTCALL lj_tab_free(global_State *g, GCtab *t); > -#if LJ_HASFFI > -LJ_FUNC void lj_tab_rehash(lua_State *L, GCtab *t); > -#endif > LJ_FUNC void lj_tab_resize(lua_State *L, GCtab *t, uint32_t asize, uint32_t hbits); > LJ_FUNCA void lj_tab_reasize(lua_State *L, GCtab *t, uint32_t nasize); > --------------i8K0um0abyhzxmjcutvmN9XM Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey

thanks for the patch! LGTM

On 19.09.2024 14:19, Sergey Kaplun wrote:
From: Mike Pall <mike>

(cherry picked from commit 87ae18af97fd4de790bb6c476b212e047689cc93)

This patch is a follow-up to the previous commit. Since the rehashing of
the finalizer table is gone, `lj_tab_rehash()` becomes unused and can be
dropped.

Sergey Kaplun:
* added the description for the patch

Part of tarantool/tarantool#10199
Follows up tarantool/tarantool#10290
---
 src/lj_tab.c | 7 -------
 src/lj_tab.h | 3 ---
 2 files changed, 10 deletions(-)

diff --git a/src/lj_tab.c b/src/lj_tab.c
index 1d6a4b7f..c99c6521 100644
--- a/src/lj_tab.c
+++ b/src/lj_tab.c
@@ -388,13 +388,6 @@ static void rehashtab(lua_State *L, GCtab *t, cTValue *ek)
   lj_tab_resize(L, t, asize, hsize2hbits(total));
 }
 
-#if LJ_HASFFI
-void lj_tab_rehash(lua_State *L, GCtab *t)
-{
-  rehashtab(L, t, niltv(L));
-}
-#endif
-
 void lj_tab_reasize(lua_State *L, GCtab *t, uint32_t nasize)
 {
   lj_tab_resize(L, t, nasize+1, t->hmask > 0 ? lj_fls(t->hmask)+1 : 0);
diff --git a/src/lj_tab.h b/src/lj_tab.h
index 71e34945..8575e7bd 100644
--- a/src/lj_tab.h
+++ b/src/lj_tab.h
@@ -41,9 +41,6 @@ LJ_FUNC GCtab * LJ_FASTCALL lj_tab_new1(lua_State *L, uint32_t ahsize);
 LJ_FUNCA GCtab * LJ_FASTCALL lj_tab_dup(lua_State *L, const GCtab *kt);
 LJ_FUNC void LJ_FASTCALL lj_tab_clear(GCtab *t);
 LJ_FUNC void LJ_FASTCALL lj_tab_free(global_State *g, GCtab *t);
-#if LJ_HASFFI
-LJ_FUNC void lj_tab_rehash(lua_State *L, GCtab *t);
-#endif
 LJ_FUNC void lj_tab_resize(lua_State *L, GCtab *t, uint32_t asize, uint32_t hbits);
 LJ_FUNCA void lj_tab_reasize(lua_State *L, GCtab *t, uint32_t nasize);
--------------i8K0um0abyhzxmjcutvmN9XM--