From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id DBA62E42CEC; Tue, 14 Jan 2025 17:11:44 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org DBA62E42CEC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1736863905; bh=C0b5DneYesp0mZsWtTip857bpY/DsMC6ttrMlkEPH+g=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=W6mRXjbsyEB8ge88/oHiv7Gkk4SbQuMz5NhuplGr6cR9hlsFASihFhOVd9oVYgZF9 Tp3jNPgJ8mnpT83V0gtauqZ4Y7UaHeYA7Q8QtXotmn5nRIp4t8L7Z3Rp6QBn5JK7b1 AVFJEFdWGlmjzigrMDZDQ5kJlSGBYDXlfd+UZAwQ= Received: from send276.i.mail.ru (send276.i.mail.ru [95.163.59.115]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 38EF64A0A19 for ; Tue, 14 Jan 2025 17:11:44 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 38EF64A0A19 Received: by exim-smtp-6758d5575c-ffljp with esmtpa (envelope-from ) id 1tXhdv-00000000Omn-1Gab; Tue, 14 Jan 2025 17:11:43 +0300 Content-Type: multipart/alternative; boundary="------------0MwB52dHxn9X0S9XaFlrHf0n" Message-ID: <48165c68-354a-41df-9c75-345aab083f7c@tarantool.org> Date: Tue, 14 Jan 2025 17:11:43 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD97BF177E4F5EB85B8BECB252C8239C4DF1537377FD6BC325300894C459B0CD1B98C1EA309C16E4B4805B18F8CB88C7B4928F207A1E1B398BEAD8B6EA4F72943A2160237749B4E196D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE79961E86438F5BDAEEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637D81244D2CF6B2D5F8638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8BABE89DE492C91692C2F349FBC94D106E9574CA4ADD1DB96CC7F00164DA146DAFE8445B8C89999728AA50765F7900637CAEE156C82D3D7D9389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC821E93C0F2A571C7BF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C4E7D9683544204AF6E0066C2D8992A164AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C3B74263D4D5690889BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE7CD707F342D9BDC98731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A50AFEF030E6C3A22A5002B1117B3ED696E1FF7870952FEF11361FAC1196A180DE823CB91A9FED034534781492E4B8EEAD0AA277257C6A5E3DBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34A5BF8FA0BD61F994AC4522C169296935C1D6A30134363B145EFBEB03A340B84AD8E776C9FCCF6A611D7E09C32AA3244C247748D277AA126B77DD89D51EBB774274FD40F44BB96FFDEA455F16B58544A2E30DDF7C44BCB90DA5AE236DF995FB59978A700BF655EAEEED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj7YQzuqfQVvxtvIpgBSJIQw== X-Mailru-Sender: 520A125C2F17F0B1E52FEF5D219D61408C1EA309C16E4B4805B18F8CB88C7B49CEFE24CBF84D01740152A3D17938EB451EB5A0BCEC6A560B3DDE9B364B0DF289BE2DA36745F2EEB5CEBA01FB949A1F1EEAB4BC95F72C04283CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/4] Improve last commit. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------0MwB52dHxn9X0S9XaFlrHf0n Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey! thanks for the patch! LGTM On 10.01.2025 16:07, Sergey Kaplun wrote: > From: Mike Pall > > (cherry picked from commit 113a168b792cd367822ec04cdc2ef32facd28efa) > > The `noconflict()` function checks if there's no conflicting instruction > between the current instruction and the given `ref` instruction. Also, > it avoids fusing loads if there are multiple references of the given > `ref`. The last check is performed in the presence of the `noload` > parameter. Since the `noconflict()`, which is added in the previous > patch, checks conflicts for the same `ref` as the call before, there is > no need to perform these checks again, so the corresponding parameter is > adjusted. > > Sergey Kaplun: > * added the description for the problem > > Part of tarantool/tarantool#10709 > --- > src/lj_asm_x86.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/lj_asm_x86.h b/src/lj_asm_x86.h > index f47c460a..cba7ba80 100644 > --- a/src/lj_asm_x86.h > +++ b/src/lj_asm_x86.h > @@ -465,7 +465,7 @@ static Reg asm_fuseload(ASMState *as, IRRef ref, RegSet allow) > } > } else if (ir->o == IR_ALOAD || ir->o == IR_HLOAD || ir->o == IR_ULOAD) { > if (noconflict(as, ref, ir->o + IRDELTA_L2S, 0) && > - noconflict(as, ref, IR_CALLS, 0) && /* Don't cross table.clear. */ > + noconflict(as, ref, IR_CALLS, 1) && /* Don't cross table.clear. */ > !(LJ_GC64 && irt_isaddr(ir->t))) { > asm_fuseahuref(as, ir->op1, xallow); > return RID_MRM; --------------0MwB52dHxn9X0S9XaFlrHf0n Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey!

thanks for the patch! LGTM

On 10.01.2025 16:07, Sergey Kaplun wrote:
From: Mike Pall <mike>

(cherry picked from commit 113a168b792cd367822ec04cdc2ef32facd28efa)

The `noconflict()` function checks if there's no conflicting instruction
between the current instruction and the given `ref` instruction. Also,
it avoids fusing loads if there are multiple references of the given
`ref`. The last check is performed in the presence of the `noload`
parameter. Since the `noconflict()`, which is added in the previous
patch, checks conflicts for the same `ref` as the call before, there is
no need to perform these checks again, so the corresponding parameter is
adjusted.

Sergey Kaplun:
* added the description for the problem

Part of tarantool/tarantool#10709
---
 src/lj_asm_x86.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lj_asm_x86.h b/src/lj_asm_x86.h
index f47c460a..cba7ba80 100644
--- a/src/lj_asm_x86.h
+++ b/src/lj_asm_x86.h
@@ -465,7 +465,7 @@ static Reg asm_fuseload(ASMState *as, IRRef ref, RegSet allow)
       }
     } else if (ir->o == IR_ALOAD || ir->o == IR_HLOAD || ir->o == IR_ULOAD) {
       if (noconflict(as, ref, ir->o + IRDELTA_L2S, 0) &&
-	  noconflict(as, ref, IR_CALLS, 0) &&  /* Don't cross table.clear. */
+	  noconflict(as, ref, IR_CALLS, 1) &&  /* Don't cross table.clear. */
 	  !(LJ_GC64 && irt_isaddr(ir->t))) {
 	asm_fuseahuref(as, ir->op1, xallow);
 	return RID_MRM;
--------------0MwB52dHxn9X0S9XaFlrHf0n--