From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id C4C8A29EAC for ; Fri, 17 Aug 2018 04:53:35 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id B9rw-ostqACl for ; Fri, 17 Aug 2018 04:53:35 -0400 (EDT) Received: from smtp2.mail.ru (smtp2.mail.ru [94.100.179.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 5AC7F29EAB for ; Fri, 17 Aug 2018 04:53:35 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH 2/2] sql: remove GLOB from Tarantool References: <4607dc428909e96915e9f0984a7733a0890a3185.1534436836.git.n.tatunov@tarantool.org> <76466086-2a5f-8f12-cbc3-4ddf26e30fd9@tarantool.org> <04D02794-07A5-4146-9144-84EE720C8656@corp.mail.ru> From: Alex Khatskevich Message-ID: <48014b63-10f8-8e65-eaca-508ec7524973@tarantool.org> Date: Fri, 17 Aug 2018 11:53:30 +0300 MIME-Version: 1.0 In-Reply-To: <04D02794-07A5-4146-9144-84EE720C8656@corp.mail.ru> Content-Type: multipart/alternative; boundary="------------70BF26E2F38F04D4F5081C4F" Content-Language: en-US Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: n.pettik@corp.mail.ru, tarantool-patches@freelists.org Cc: "N. Tatunov" , Alexander Turenko This is a multi-part message in MIME format. --------------70BF26E2F38F04D4F5081C4F Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: 8bit Accepted. On 17.08.2018 11:37, n.pettik@corp.mail.ru wrote: > >> On 17 Aug 2018, at 11:25, Alex Khatskevich >> > wrote: >> >>> GLOB is a legacy extension for LIKE from SQLite. As we want our SQL to >>> be close to ANSI SQL & LIKE to depend on collations, we do not want to >>> support it. This patch totally removes it from Tarantool along with any >>> mentions of it. >> 1.We delete it because it is not working properly, and instead of >> fixing it we >> want to replace it with more general regexp. Delete other unnecessary >> thoughts >> from this message. >> 2. Do not use "we", "our" in commit messages. > > Why? Ofс it would sound more like documentation, but AFAIK we don’t > force this restriction. You can check out commit messages from other > contributors who use ‘we’ and ‘I': > > https://github.com/tarantool/tarantool/commit/f4625e64eb99c17910d3f0bcd323e5d82b6d5b31 > https://github.com/tarantool/tarantool/commit/46f50aadedfa87a16e2618da55924b185376b58a > https://github.com/tarantool/tarantool/commit/1331d232476f17b9ec5be45175233d1b5454d1fd > > etc > --------------70BF26E2F38F04D4F5081C4F Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit

Accepted.


On 17.08.2018 11:37, n.pettik@corp.mail.ru wrote:

On 17 Aug 2018, at 11:25, Alex Khatskevich <avkhatskevich@tarantool.org> wrote:

GLOB is a legacy extension for LIKE from SQLite. As we want our SQL to
be close to ANSI SQL & LIKE to depend on collations, we do not want to
support it. This patch totally removes it from Tarantool along with any
mentions of it.
1.We delete it because it is not working properly, and instead of fixing it we
want to replace it with more general regexp. Delete other unnecessary thoughts
from this message.
2. Do not use "we", "our" in commit messages.

Why? Ofс it would sound more like documentation, but AFAIK we don’t
force this restriction. You can check out commit messages from other
contributors who use ‘we’ and ‘I':


etc


--------------70BF26E2F38F04D4F5081C4F--