From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp5.mail.ru (smtp5.mail.ru [94.100.179.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8B3C7440F3E for ; Wed, 13 Nov 2019 01:58:25 +0300 (MSK) References: From: Vladislav Shpilevoy Message-ID: <47d31f47-c137-f46e-d695-cf962f0d5ab0@tarantool.org> Date: Wed, 13 Nov 2019 00:04:33 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH 0/2] Add constraint names hash table to space List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Roman Khabibov , tarantool-patches@dev.tarantool.org Hi! Thanks for the patchset! On 12/11/2019 15:02, Roman Khabibov wrote: > I know, that this patchset requires more tests. I will add them in > the next answer. For now look at the code. > Please, write tests, if you have more. All the new code should be covered. Tests are needed regardless of what I am going to comment. Put branch and issue links here, not in the end. Otherwise they are considered a comment in my email client, and are not added to a response email. > Roman Khabibov (2): > box: introduce constraint names hash table > sql: make constraint operations transactional > > src/box/alter.cc | 254 +++++++++++++++++++++++++++++-- > src/box/space.c | 46 ++++++ > src/box/space.h | 40 +++++ > test/sql-tap/constraint.test.lua | 244 +++++++++++++++++++++++++++++ > 4 files changed, 574 insertions(+), 10 deletions(-) > create mode 100755 test/sql-tap/constraint.test.lua >