From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id AB798469719
 for <tarantool-patches@dev.tarantool.org>;
 Tue,  3 Nov 2020 00:13:16 +0300 (MSK)
References: <cover.1603360022.git.tsafin@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <479c22dc-feaf-667f-4f9e-9843ebe1e932@tarantool.org>
Date: Mon, 2 Nov 2020 22:13:14 +0100
MIME-Version: 1.0
In-Reply-To: <cover.1603360022.git.tsafin@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 0/2] module_api: followup changes
 for merger part
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Timur Safin <tsafin@tarantool.org>, alexander.turenko@tarantool.org
Cc: tarantool-patches@dev.tarantool.org

Hi! I don't see a branch name. And can't find anything by '5384' in
name.

On 22.10.2020 12:20, Timur Safin wrote:
> There were few complains about comments in the patchset sent
> for issue #5384:
> - we have been asked to extend reasonably ibuf.h documentation, making 
>   it more self-contained;
> - and to fix module_api test comments, making them more doxygen
> 
> P.S.
> Actualy I don't know whether we really want it be committed to the 
> 2.6 we plan to release soon. But looks like commenting changes 
> in the external API might still be a good idea. You decide.
> 
> Timur Safin (2):
>   module api: proper documentation for the ibuf wrapper
>   module api: polish module_api test
> 
>  src/box/ibuf.h            | 33 ++++++++++++++++++++++++++++++---
>  test/app-tap/module_api.c |  8 ++++----
>  2 files changed, 34 insertions(+), 7 deletions(-)
>