From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 4184F2968C for ; Tue, 21 Aug 2018 12:31:24 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id idXth9XOVLl8 for ; Tue, 21 Aug 2018 12:31:24 -0400 (EDT) Received: from smtp63.i.mail.ru (smtp63.i.mail.ru [217.69.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id E13BC29359 for ; Tue, 21 Aug 2018 12:31:23 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: [tarantool-patches] Re: [PATCH 06/10] sql: completely remove support of partial indexes From: "n.pettik" In-Reply-To: Date: Tue, 21 Aug 2018 19:31:22 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <47821985-7073-47BD-9235-207F782EEF1A@tarantool.org> References: <426c951a553688d1a07139596f79512a2caa6c28.1534001739.git.korablev@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: Vladislav Shpilevoy > On 13 Aug 2018, at 23:24, Vladislav Shpilevoy = wrote: >=20 > Thanks for the patch! I have pushed my review fixes in > a separate commit. >=20 > Please, investigate also is it possible to remove pPartial > variable from constructAutomaticIndex? It would allow to > remove sql_resolve_part_idx_label alongside. ConstructAutomatiIndex() is now dead code, so I can=E2=80=99t really = check it. Lets now remove it. I doubt that this code can be adapted easily, so it is likely to be re-implemented anyway.=