From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id A3B6FA69E54; Thu, 11 Apr 2024 10:56:50 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A3B6FA69E54 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1712822210; bh=ZKc9JxHb4tGshOTDmRESywstue6mb19PAYruJgSp9Hk=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=DN7MsazcQt0yAC8zPwDX8zssOrk03YvvoWKJ259OBrziSdyPCVSUcuyxnO3rrd4VT ceUtwUfXgRE9TZR5kb6qZgCIobjqeCOfKIqmPCrs907/ExtkaDzpb0osaUs7EvZlgk IlsfiAh31t+lVEiNf1sup8I6t5FvZ3i01NubNk+Q= Received: from smtp42.i.mail.ru (smtp42.i.mail.ru [95.163.41.65]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 099C0A69E40 for ; Thu, 11 Apr 2024 10:56:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 099C0A69E40 Received: by smtp42.i.mail.ru with esmtpa (envelope-from ) id 1rupIe-0000000ER4m-0UgW; Thu, 11 Apr 2024 10:56:48 +0300 Message-ID: <474e3271-ed64-4296-aaf7-8de66b1b1700@tarantool.org> Date: Thu, 11 Apr 2024 10:56:47 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Sergey Kaplun , Sergey Bronnikov References: <1fe5f0ebbd285bd58849be28548bcc8c8c68c2a1.1710416150.git.sergeyb@tarantool.org> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD91C726AF9233A4C6FA8143870728B8272760BE0FCA97B72EC1313CFAB8367EF908E2BE116634AD74D0B3A5F88CF7A160E672D9F60861A48B2739D30D08554E2245809207A721590FD1E39E150AE5B0BE1 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7D9C4478D0B876341EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006373CF509324F67ED188638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D81B5E1C9106BC5C5843AF92C7A559868F92170277AA82B7F9CC7F00164DA146DAFE8445B8C89999728AA50765F7900637CAEE156C82D3D7D9389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC81D471462564A2E19F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947CF254576263B31EA903F1AB874ED890284AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C3E454F552B5E65C9ABA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CFED8438A78DFE0A9E1DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3F8A0C55DE5E8D0B235872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A567CC0B66432175E65002B1117B3ED696A786C4A0408D7D931A1B8FE1FED62FE8823CB91A9FED034534781492E4B8EEAD2B25D9E4C92BC8ACBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFBBA117C5D8738C4D6EC42A2214C574B6D3D56BA92872356A4D00E19CA822C941A7F6D8DEE3A50DD443A9A4803F78FBB918EA19A1C1F52CF8A5784C579D7964C28792DFCBE39E1B49C226CC413062362A913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioja81YqLNwFpmOrV6LbxI6/g== X-Mailru-Sender: 520A125C2F17F0B1A9638AD358559B5920BA9269AC37AB6703ED270C30F246C5FEC9C17177CF96E7B7CBEF92542CD7C8795FA72BAB74744FC77752E0C033A69EA16A481184E8BB1C9B38E6EA4F046BE03A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/2] OSX/iOS/ARM64: Fix bytecode embedding in Mach-O object file. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, thanks for review! On 08.04.2024 18:16, Sergey Kaplun wrote: > Hi, Sergey! > The version on branch LGTM, except a single nit regarding the commit > message below. > > On 14.03.24, Sergey Bronnikov wrote: >> From: sergeyb@tarantool.org >> >> Thanks to Carlo Cabrera. >> >> (cherry picked from commit b98b37231bd2dcb79e10b0f974cefd91eb0d7b3a) >> >> Mach-O FAR object files generated by LuaJIT for arm64 had an incorrect > Typo: s/FAR/FAT/ It was already highlighted by Maxim, see https://lists.tarantool.org/tarantool-patches/ZhPrxdZKzOVXVChp@root/T/#t >> format because FFI structure used for generation was wrong: >> `mach_fat_obj` instead of `mach_fat_obj_64`. > I suggest reformulating this as the following: > > | Mach-O FAT object files generated by LuaJIT for arm64 had an incorrect > | format due to the usage of the 32-bit version of FFI structure. > | This patch adds the 64-bit structure definition and uses it for arm64. Updated. >> Sergey Bronnikov: >> * added the description and a test for the problem >> >> Part of tarantool/tarantool#9595 >> --- >> src/jit/bcsave.lua | 14 +++++++++++++- >> ...-fix_generation_of_mach-o_object_files.test.lua | 4 +++- >> 2 files changed, 16 insertions(+), 2 deletions(-) >> >> diff --git a/src/jit/bcsave.lua b/src/jit/bcsave.lua >> index 7aec1555..069cf1a3 100644 >> --- a/src/jit/bcsave.lua >> +++ b/src/jit/bcsave.lua > > >> diff --git a/test/tarantool-tests/lj-865-fix_generation_of_mach-o_object_files.test.lua b/test/tarantool-tests/lj-865-fix_generation_of_mach-o_object_files.test.lua >> index 0519e134..0a11f163 100644 >> --- a/test/tarantool-tests/lj-865-fix_generation_of_mach-o_object_files.test.lua >> +++ b/test/tarantool-tests/lj-865-fix_generation_of_mach-o_object_files.test.lua > > >> -- >> 2.34.1 >>