From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp51.i.mail.ru (smtp51.i.mail.ru [94.100.177.111])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 33A1046970E
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 25 Dec 2019 19:00:58 +0300 (MSK)
References: <cover.1577277455.git.sergepetrenko@tarantool.org>
 <42999683415fb48efba3821b59ef7e62ad00cf16.1577277455.git.sergepetrenko@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <473fde0d-7dfb-1dcd-a608-63e0ad78d20f@tarantool.org>
Date: Wed, 25 Dec 2019 17:00:55 +0100
MIME-Version: 1.0
In-Reply-To: <42999683415fb48efba3821b59ef7e62ad00cf16.1577277455.git.sergepetrenko@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v2 4/5] vclock: ignore 0th component
 in comparisons.
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: sergepetrenko <sergepetrenko@tarantool.org>, Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Thanks for working on this!

The first 4 commits LGTM. I've force pushed a tiny
nit fix below:

diff --git a/src/box/vclock.h b/src/box/vclock.h
index 35ba6284c..5d1a50d3d 100644
--- a/src/box/vclock.h
+++ b/src/box/vclock.h
@@ -289,7 +289,6 @@ vclock_compare(const struct vclock *a, const struct vclock *b)
 		replica_id = bit_iterator_next(&it);
 
 	for (; replica_id < VCLOCK_MAX; replica_id = bit_iterator_next(&it)) {
-
 		int64_t lsn_a = vclock_get(a, replica_id);
 		int64_t lsn_b = vclock_get(b, replica_id);
 		le = le && lsn_a <= lsn_b;