From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 2B05EA61F42; Tue, 26 Mar 2024 18:22:08 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 2B05EA61F42 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1711466528; bh=iv35L7sLeKhRKz1x4uBbb1ZKJWbh4kJXZ9+OVEpD1NM=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=oUAYW2nEMum0KY8bL9/+9sFMPRlqX3atNFTMK0JWarlB/wR8dnytSPg0TKQnIGJam CPRZjYtbTElBAnyPGgAtOlWWM8xO0BKQZM4LnZ32hVqsfSuKAxD44b6yA2BHkQ2dzT Vzd3jf6HWiBPU37uYRY2HjZUclygeK3wStCG+U3o= Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [95.163.41.99]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 03F94B85E35 for ; Tue, 26 Mar 2024 18:22:07 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 03F94B85E35 Received: by smtp61.i.mail.ru with esmtpa (envelope-from ) id 1rp8cm-0000000FEtj-48p8; Tue, 26 Mar 2024 18:22:05 +0300 Message-ID: <46dabb52-390b-44a5-89a4-9ab3a3918f93@tarantool.org> Date: Tue, 26 Mar 2024 18:22:04 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun , Sergey Bronnikov References: <19e2e200fa5da4d6fb6875e599b9f8bd0a0048b9.1711441864.git.sergeyb@tarantool.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD905284D235AF2CB5320E1A444C4A1C2469014C60A21042FE5182A05F53808504013B5A8DEDBAEB6B0411046492FDDF8063D9234B21EB09E6B33083C2B4D92DB82A92BA30E35CD8A73 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7AE28AD3C7270E452C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE7C59BC9C4992485738F08D7030A58E5AD1A62830130A00468AEEEE3FBA3A834EE7353EFBB5533756643209340834BB997AD7EFFAEDA55A9D81751F978785A8A4CC7DEAC16A93970AB389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C04CF195F1528592878941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6D52CD31C43BF465FCC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C224947D5CDDEEDCB0F0076E601842F6C81A12EF20D2F80756B5FB606B96278B59C4276E601842F6C81A127C277FBC8AE2E8BDB6EFB23523380DB3AA81AA40904B5D99C9F4D5AE37F343AD1F44FA8B9022EA23BBE47FD9DD3FB595F5C1EE8F4F765FC8C7ADC89C2F0B2A5E2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B3BBA039523A4428275ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A5DE09F3E2587A98025002B1117B3ED696BCDEC02C4D9357C2957033528158102E823CB91A9FED034534781492E4B8EEADEEA082C9A12FE455BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFDAF8DBE9B4167F04A7BA50B7BE6B414FB3A4446CBCC759072CF610BABD9BE4F791CDF2D949345910F212F37558E72466AFC3554E887C481442C01FFD4C999FCD7FFCEC9AA17E526CC226CC413062362A913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojhu0AwaaKnHrntiGZ5/fs8Q== X-Mailru-Sender: 520A125C2F17F0B1A9638AD358559B596D02CA3D5C43798E411046492FDDF8063D9234B21EB09E6BB7CBEF92542CD7C8795FA72BAB74744FC77752E0C033A69EA16A481184E8BB1C9B38E6EA4F046BE03A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 5/6] test: fix lj-802-panic-at-mcode-protfail GCC+ASan X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Sergey, On 3/26/24 13:08, Sergey Kaplun wrote: > Hi, Sergey! > Thanks for the patch! > LGTM, except 2 typos regarding the commit message and the comment. > > On 26.03.24, Sergey Bronnikov wrote: >> From: Sergey Kaplun >> >> The aforementioned test uses `LD_PRELOAD` to mock the system call to >> `mprotect()`. The GCC implementation of libasan requires that the ASan >> library go first in the `LD_PRELOAD` list. This patch tweaks the >> behaviour to avoid failure of the test. OTOH, this patch intorduces > Typo: s/intorduces/introduces/ > Fixed. >> warnings related to the libc leaks for a couple of tests, but they are >> not treated as test failures. This should be fixed by target setting >> LD_PRELOAD only for necessary tests when we start using CTest instead of >> `prove`. >> >> Part of tarantool/tarantool#9656 >> >> Co-authored-by: Sergey Bronnikov >> --- >> test/tarantool-tests/CMakeLists.txt | 15 +++++++++++++++ >> test/tarantool-tests/utils/exec.lua | 14 ++++++++++++++ >> 2 files changed, 29 insertions(+) >> >> diff --git a/test/tarantool-tests/CMakeLists.txt b/test/tarantool-tests/CMakeLists.txt >> index e6d12984..35bcc5ef 100644 >> --- a/test/tarantool-tests/CMakeLists.txt >> +++ b/test/tarantool-tests/CMakeLists.txt >> @@ -110,6 +110,21 @@ else() >> list(APPEND LUA_TEST_ENV_MORE LD_LIBRARY_PATH=${LD_LIBRARY_PATH}) >> endif() >> >> +# Some tests use `LD_PRELOAD` to mock system calls (like >> +# overwrites >> +# `mprotect()`. When compiling with ASan support under GCC, it is >> +# required that the ASan library go first in the `LD_PRELOAD` >> +# list. Set it manually, test will append it to the executed > Typo: s/manually, test/manually. The test/ > Fixed. >> +# process. >> +# See also: https://github.com/tarantool/tarantool/issues/9656. > > >> -- >> 2.34.1 >>