From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id A93E414549E1; Mon, 21 Jul 2025 15:38:49 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A93E414549E1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1753101529; bh=7z5Duy8rE9GxgN2Kw63lfQxn6j2nHisx4ELDPJxK8jg=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=zvpd6IIZeMF/7GqODuVdYvjoJe4H7kelLPP26okAws/cJcJTqW+yfFo1PJOXbLe+Q dgoHz0cmBpXgw4OO2rkCFWv54Dw/CJzVlZvrywEyMGnL1t6u2oH4bUT8G/v4UxThS9 u+p/7N2YflmNeagNJv8IbVzfN3afE69y1s8eIlnc= Received: from send243.i.mail.ru (send243.i.mail.ru [95.163.59.82]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id AA87D14549D6 for ; Mon, 21 Jul 2025 15:38:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org AA87D14549D6 Received: by exim-smtp-6db95c9866-qzpg8 with esmtpa (envelope-from ) id 1udpn5-00000000EEy-24U7; Mon, 21 Jul 2025 15:38:47 +0300 Content-Type: multipart/alternative; boundary="------------AhmB4cfLGJJE3NKqdNgOqqDb" Message-ID: <46b724d0-8786-4bf3-aa14-747b8ff9e220@tarantool.org> Date: Mon, 21 Jul 2025 15:38:46 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: <20250721081627.4837-1-skaplun@tarantool.org> <7c148026-9ddc-4b6e-898a-b84c170c0eb2@tarantool.org> Content-Language: en-US In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9B9F43B9EFA5FD564E363CDCD220E7B1529BEF497738E92D6182A05F5380850409E6712AAB3B084D63DE06ABAFEAF67051C13FDEF0E8FC821CF2EF8CE88632A7522AF0AD8BA8DF889 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE701173C01F417A2A6EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB55337566EBA330160BAF42EE4FB014A921FA5A2F596193463658E1E141E2985896463781389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C0A3E989B1926288338941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B636DA1BED736F9328CC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB8D32BA5DBAC0009BE9E8FC8737B5C2249B899183D4666AAE776E601842F6C81A12EF20D2F80756B5FB606B96278B59C4276E601842F6C81A127C277FBC8AE2E8B89C074F960B19C4B3AA81AA40904B5D99C9F4D5AE37F343AD1F44FA8B9022EA23BBE47FD9DD3FB595F5C1EE8F4F765FC72CEEB2601E22B093A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E7352B32DCB92A8600C6C4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A5E4BE09EC8056C9E15002B1117B3ED696A73A3E1E2E69A175C66B2B37046EC955823CB91A9FED034534781492E4B8EEADD0953842B444AAC3BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D341C998A3771F04153AFF155EEFB57D8A284EA49800092F794ABE28804CF4BB79F4072BA4790B05DA61D7E09C32AA3244C859FEB4E06F4C90477DD89D51EBB77428155A439C8130603EA455F16B58544A2E30DDF7C44BCB90DA5AE236DF995FB59978A700BF655EAEEED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVU4HtwWQGdJGposO8pjKXaY= X-Mailru-Sender: 4C2B2EA4912B1EDDF1101D80EC0F151220B4701B571B19993DE06ABAFEAF67051C13FDEF0E8FC821B7CBEF92542CD7C8795FA72BAB74744FC77752E0C033A69EA16A481184E8BB1C9B38E6EA4F046BE03A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] test: disable lj-1196 for Tarantool or x86/x64 X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------AhmB4cfLGJJE3NKqdNgOqqDb Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit LGTM On 7/21/25 15:29, Sergey Kaplun wrote: > Hi, Sergey! > Thanks for the review! > > On 21.07.25, Sergey Bronnikov wrote: >> Hello, Sergey, >> >> thanks for the patch! >> >> > [PATCH luajit] test: disable lj-1196 for Tarantool or x86/x64 >> >> s/or/on/? > No, since I've meant that either Tarantool or the corresponding arch > doesn't run this test. > >> On 7/21/25 11:16, Sergey Kaplun wrote: >>> The test may lead to the assertion failure if run under Tarantool. >>> Also, the skip condition for the Tarantool leads to stable fails for >>> some builds on x86/x64 architecture, so they are skipped as well. >>> See details in the comment to the skip conditions. >>> --- >> I suppose you want to disable it temporarily, do we need an issue as a >> reminder? > I suppose not. It should be enabled back alongside the backporting > commit for the 1369. > >> LGTM >>> Branch:https://github.com/tarantool/luajit/tree/skaplun/disable-lj-1196-tarantool >>> >>> Originally I want to disable the test only for Tarantool, but faced >>> multiple failures in the different workflows: >>> https://github.com/tarantool/luajit/actions/runs/16410069543 >>> > > --------------AhmB4cfLGJJE3NKqdNgOqqDb Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

LGTM

On 7/21/25 15:29, Sergey Kaplun wrote:
Hi, Sergey!
Thanks for the review!

On 21.07.25, Sergey Bronnikov wrote:

Hello, Sergey,

thanks for the patch!

 > [PATCH luajit] test: disable lj-1196 for Tarantool or x86/x64

s/or/on/?

No, since I've meant that either Tarantool or the corresponding arch
doesn't run this test.


On 7/21/25 11:16, Sergey Kaplun wrote:

The test may lead to the assertion failure if run under Tarantool.
Also, the skip condition for the Tarantool leads to stable fails for
some builds on x86/x64 architecture, so they are skipped as well.
See details in the comment to the skip conditions.
---

I suppose you want to disable it temporarily, do we need an issue as a 
reminder?

I suppose not. It should be enabled back alongside the backporting
commit for the 1369.


LGTM

Branch:https://github.com/tarantool/luajit/tree/skaplun/disable-lj-1196-tarantool

Originally I want to disable the test only for Tarantool, but faced
multiple failures in the different workflows:
https://github.com/tarantool/luajit/actions/runs/16410069543


<snipped>
--------------AhmB4cfLGJJE3NKqdNgOqqDb--