From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp62.i.mail.ru (smtp62.i.mail.ru [217.69.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B9E88469719 for ; Sat, 29 Feb 2020 02:24:56 +0300 (MSK) References: From: Vladislav Shpilevoy Message-ID: <46414642-29a4-fb65-acc1-67bce6da14fb@tarantool.org> Date: Sat, 29 Feb 2020 00:24:55 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH v5 2/4] wal: warn when trying to write a record with a broken lsn List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Serge Petrenko Cc: kirichenkoga@gmail.com, tarantool-patches@dev.tarantool.org On 28/02/2020 09:34, Serge Petrenko wrote: > There is an assertion in vclock_follow `lsn > prev_lsn`, which doesn't > fire in release builds, of course. Let's at least warn the user on an > attemt to write a record with a duplicate or otherwise broken lsn, and attemt -> attempt I fixed that on the branch by a force push.