From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 1EBAE262E9 for ; Mon, 9 Jul 2018 06:20:12 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id n2oJgbtJZDj0 for ; Mon, 9 Jul 2018 06:20:12 -0400 (EDT) Received: from smtp59.i.mail.ru (smtp59.i.mail.ru [217.69.128.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id CF40F25A57 for ; Mon, 9 Jul 2018 06:20:11 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v1 1/2] sql: get rid off sqlite3NestedParse in clean stats References: <355d8c55-abc7-a088-8dba-6fb3bff32b51@tarantool.org> From: Vladislav Shpilevoy Message-ID: <462a6bf7-d111-b297-7363-96e938c0b25c@tarantool.org> Date: Mon, 9 Jul 2018 13:20:09 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, Kirill Shcherbatov Hello. Thanks for the fixes! I have force pushed my two-line minor fix of a comment on the branch. >> Also I have found that vdbe_emit_open_cursor() has the second >> parameter named 'index_id', but in some places the function >> takes real index_id, in other places it takes tnum, and in vdbe >> it is interpreted as tnum. Please, fix this mess in a separate >> commit. I think, we should always pass index_id. > I've tried to do this and I'll append my diff to the end of this message, > but there are some strange things.. > This should be investigated separately. I don't mind to do this, but I believe > that this may delayed to be not a part of "remove sqlite3NestedParse function". > > Take a look at the end of this message. Then fix this please on a separate branch. If it is easy, then it can be done without an issue. If it takes more than 4 hours, then create an issue, please.