From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp63.i.mail.ru (smtp63.i.mail.ru [217.69.128.43])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 5BFFE440F3C
 for <tarantool-patches@dev.tarantool.org>;
 Wed,  6 Nov 2019 17:43:09 +0300 (MSK)
References: <cover.1572965692.git.v.shpilevoy@tarantool.org>
 <848b353e29d6a692ce4e7015723cad31aa42b8dd.1572965692.git.v.shpilevoy@tarantool.org>
 <20191105181830.GL29784@atlas>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <45dad4ec-5449-0d76-8ffd-55f0ea15f674@tarantool.org>
Date: Wed, 6 Nov 2019 17:49:01 +0300
MIME-Version: 1.0
In-Reply-To: <20191105181830.GL29784@atlas>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 2/3] error: move errno into an error
	object
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Konstantin Osipov <kostja.osipov@gmail.com>, tarantool-patches@dev.tarantool.org



On 05/11/2019 21:18, Konstantin Osipov wrote:
> * Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/11/05 17:57]:
> 
> syserror is a non-obvious name, I realize you can't use errno
> since it is a macro, you could use save_errno, sys_errno,
> m_errno, anything that would make it obvious it is a saved errno 
> (saved_errno?) instead.

Yes, I tried to use just 'errno', but seems like it can be a macros.

m_errno is rather C++ style. Sys_errno sounds tautological - errno
presumes 'sys'.

I choose 'saved_errno'.

Renamed on the branch.