From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id F1C376EC5B; Tue, 30 Mar 2021 01:57:25 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org F1C376EC5B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617058646; bh=BEm51/2AE3n0/s3mPkHhbRlZ6gSKerLjAPdsHUcq2vg=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=UkcBoAAaot06OJCbnwx/xbl/j1G/Q6JrdHbWqAmdvY9BCJOsNKRYfQWX0LARPjLaw EFgwwvm62WPsFdje4YH1e9ORZ8a7OjLeFTtWFJ8kmcqdLkoRCroSYoD1ID+LIzdGqg QWhGLOr0nQ/fgZRgFlDRbIdUfphhVUjpJ80a+q8I= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 801CE6EC5B for ; Tue, 30 Mar 2021 01:57:24 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 801CE6EC5B Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1lR0p1-0004ND-QB; Tue, 30 Mar 2021 01:57:24 +0300 To: imeevma@tarantool.org, tsafin@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: Message-ID: <452c313f-878a-bb26-b227-83e61d2dac48@tarantool.org> Date: Tue, 30 Mar 2021 00:57:22 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947427BE79D20CABD4F844F00D7AFD5C3C182A05F5380850402B7F03C72B070578AF8BFCEBCF7DB654713D943953D0D6E8B1A28AB0406DD31C X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE77633BACAB33B9508C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE754CF51794FD91028EA1F7E6F0F101C67CDEEF6D7F21E0D1D174C73DBBBFC7664AF392B77D6B6B3810E711EC46B44E26CC006AA173933E477389733CBF5DBD5E913377AFFFEAFD269A417C69337E82CC2CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C078FCF50C7EAF9C588941B15DA834481F9449624AB7ADAF372E808ACE2090B5E14AD6D5ED66289B5259CC434672EE6371089D37D7C0E48F6C8AA50765F7900637AD0424077D726551EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C97831B7DABD8F4FAFB02F45A0E006394C2ED0 X-C1DE0DAB: 0D63561A33F958A58246B7D897AF84635ACD1814E08F507DB55BDCB0E7D92778D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3455AC8BF8E3153BA025EE9B4AB352F8E08E5BCA896A69816D23386223246314AC93713BE7B439CEE51D7E09C32AA3244C71C3BB63D58243C7D8ED60EFAAA649B6795D98D676DD64D0FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojljIiQOC84rTjkdLBN3mT7g== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822A8381F77ADCC5CBCB29C895DC2969F373841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v4 01/53] sql: enchance vdbe_decode_msgpack_into_mem() X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! I appreciate the work you did here! Truly huge patch. But it does the important thing which I think should give a huge help in the task of SQL code rework. On 23.03.2021 10:34, Mergen Imeev via Tarantool-patches wrote: > Currently, vdbe_decode_msgpack_into_mem() creates a MEM that is not > properly initialized in case msgpack contains MP_EXT, MP_MAP, or > MP_ARRAY fields. Also, it doesn't set field_type. AFAIR, field type wasn't set deliberately. Because we use it only for strictly typed values obtained from formatted space fields. It wasn't applied to plain non-formatted values on purpose. Why do you change that?