From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 21E506EC5B; Tue, 30 Mar 2021 01:59:25 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 21E506EC5B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617058765; bh=IWQ0AXhA+ZwaMGupZIMl5telRWaUwI65IfRQXV9rzRQ=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=XJit+x2eNKugueW8rjUJhRMJe4UYSfDwFK6wy7lM2SA6MmA4uNjO/9V4O5wRL2F8M RxX02VsHaZqhBvpRAcbWXZ87kyYrD7vGxz/B7cmFkWLeptJb2XLkgAso2+39fZg9BG 4XC1BEQx9QBFhc3ZyD76H+1e7aZXkrl4Al8dW6ag= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B2F086EC5B for ; Tue, 30 Mar 2021 01:58:43 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B2F086EC5B Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1lR0qI-0004rA-Sh; Tue, 30 Mar 2021 01:58:43 +0300 To: imeevma@tarantool.org, tsafin@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: <9830a56f8bd4ff73f69238e350b48e3941f88e29.1616491731.git.imeevma@gmail.com> Message-ID: <4495b87f-d470-fed1-ee12-984d193913f8@tarantool.org> Date: Tue, 30 Mar 2021 00:58:41 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <9830a56f8bd4ff73f69238e350b48e3941f88e29.1616491731.git.imeevma@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 78E4E2B564C1792B X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E32947427BE79D20CABD4F844F00D7AFD5C3C182A05F538085040E3DBF212B75085FA30CAB707454923BC9779B53A64EBE8FD312BC1CB760CA680 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7E5D7EAC6EBA58433EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006372E9841F416E2DCCD8638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95CE99938B3FD79E1DFBC11D071510579FC54094EC3CDB824C6A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE71AE4D56B06699BBC9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C3E478A468B35FE767117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947C0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735F409322A2F59C95CC4224003CC83647689D4C264860C145E X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2AD77751E876CB595E8F7B195E1C978310EE0AF4058D65218B24383D33A8A987E X-C1DE0DAB: 0D63561A33F958A5AD239C349F1B03A4D60BDE4FB61258FF35369456F25EAF50D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34BC3EEE75EF3BACCF22F2C77E7AC61A7CBE3213C4EE1E3E08BD75333AA3E84976B0A8456EFA7B44341D7E09C32AA3244CB068F937E9A4ACD066F1260839B1D05FC86C126E7119A0FEFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojljIiQOC84rRCITxmKy9XeA== X-Mailru-Sender: 689FA8AB762F73936BC43F508A06382203AD5F48F2A0ABCA5421CDD5C87C2B643841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v4 07/53] sql: disable unused code in sql/vdbemem.c X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the patch! I didn't even know we have vdbemem.c. It should be deleted someday when we have mem.h/mem.c instead. > diff --git a/src/box/sql/sqlInt.h b/src/box/sql/sqlInt.h > index dd8163f5e..b4293d961 100644 > --- a/src/box/sql/sqlInt.h > +++ b/src/box/sql/sqlInt.h > @@ -4151,31 +4151,54 @@ sql_expr_new_column(struct sql *db, struct SrcList *src_list, int src_idx, > > int sqlExprCheckIN(Parse *, Expr *); > > -int sqlStat4ProbeSetValue(Parse *, struct index_def *, UnpackedRecord **, Expr *, int, > - int, int *); > -int sqlStat4ValueFromExpr(Parse *, Expr *, enum field_type type, > - sql_value **); > -void sqlStat4ProbeFree(UnpackedRecord *); > +/* TODO: Enable this function when stat-tables will be revived. */ > +static inline int > +sqlStat4ProbeSetValue(struct Parse *parse, struct index_def *def, > + struct UnpackedRecord **rec, struct Expr *expr, int n, > + int i, int *out) You can also make it take '...' instead of all of these arguments individually. The same for the other functions. > +{ > + (void)parse; > + (void)def; > + (void)rec; > + (void)expr; > + (void)n; > + (void)i; > + (void)out; > + unreachable(); > + return 0; > +}