From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id D21AF26EE9 for ; Thu, 29 Aug 2019 04:28:23 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RlZvHF3-eyAR for ; Thu, 29 Aug 2019 04:28:23 -0400 (EDT) Received: from smtp39.i.mail.ru (smtp39.i.mail.ru [94.100.177.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 8A1FB26EE6 for ; Thu, 29 Aug 2019 04:28:23 -0400 (EDT) From: Georgy Kirichenko Subject: [tarantool-patches] Re: [PATCH] Iproto call won't leak if transaction isn't committed Date: Thu, 29 Aug 2019 11:28:14 +0300 Message-ID: <4468891.FtR9PfF7uI@localhost> In-Reply-To: <20190828143235.44805-1-maria.khaydich@tarantool.org> References: <20190828143235.44805-1-maria.khaydich@tarantool.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart13063206.23HALITn4Z"; micalg="pgp-sha256"; protocol="application/pgp-signature" Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Maria Khaydich --nextPart13063206.23HALITn4Z Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Merged into 2.3, 2.2 and 1.10 as it affects all this versions On Wednesday, August 28, 2019 5:32:35 PM MSK Maria Khaydich wrote: > In case of throwing client error because of unfinished > transaction we did not destroy used port. It could possibly > cause huge memory leaks as could be seen with top or its > analogues when performing net.box test run in a loop. > > Closes #4388 > --- > Issue: > https://github.com/tarantool/tarantool/issues/4388 > Branch: > https://github.com/tarantool/tarantool/tree/eljashm/gh-4388-uncommitted-ipro > to-leaks-not > > src/box/call.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/box/call.c b/src/box/call.c > index ac2bf3004..169210767 100644 > --- a/src/box/call.c > +++ b/src/box/call.c > @@ -132,6 +132,7 @@ box_process_call(struct call_request *request, struct > port *port) > > if (txn != NULL) { > diag_set(ClientError, ER_FUNCTION_TX_ACTIVE); > + port_destroy(port); > txn_rollback(txn); > fiber_gc(); > return -1; --nextPart13063206.23HALITn4Z Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEFZT35EtIMRTDS5hJnoTdFFzh6LUFAl1njJ4ACgkQnoTdFFzh 6LWJIAf8CclTYIWG7ZLvugIWxwOJC6LpfmgOAWQNCngAUz4ZcUsCQVa4uCTAfOX2 o8ha8nbaM1SZ2+ytxD4nHtFQOGdVH42VY/a6dz5nsaffW2OKJdumVWS5000Z3twn JrPhOvH/pr8ckMn/X3dMqBJcMefnLusOPIz8itOJTB9syj4xUrJX2cNlxyC9sca3 MyWoy8TUdFEj3Lr3RH8X4XfvJGEmRRwp3QXKQH0Z9ey+IHBU+qfF0NTaq6wJ2lSS eNWoD6zMHetxHwCuzUHkh4snvO8jDPicgWrkYPAy6JZxG71cCI7l6ymh2kNPsFeg VwywvrgCd9KatHKU1A5yHfHKWyoXLw== =dUsm -----END PGP SIGNATURE----- --nextPart13063206.23HALITn4Z--