From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id A57117414D; Tue, 5 Oct 2021 00:54:53 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A57117414D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1633384493; bh=2EqjumNLxH6T2UznP0e69t7DQ6gYfAyfrxekziPos2Y=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=H1KBEQTpPJKkbQQkAmyNkcAFjSIk15ZMxPjP1rQqsBKpM+u/GCygDAUsGZ6j+tdNr 9nMiZBbn7ohUIFLLtgRcD/i5bO9lCb1sL9IT0U3227KhTnOcTzQNFJ30Kz8RNneBJl T8LZ626r1iHxfS4llKX2CrQL304K0DsBdtuLCjQk= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6DD8F7414D for ; Tue, 5 Oct 2021 00:54:12 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6DD8F7414D Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1mXVuV-0005LC-Oe; Tue, 05 Oct 2021 00:54:12 +0300 To: imeevma@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: <440e898334cae0debebd83d8cde70bbda150f2e9.1633092363.git.imeevma@gmail.com> Message-ID: <445b19bf-c2b4-b243-22cc-ed9eebb0a464@tarantool.org> Date: Mon, 4 Oct 2021 23:54:10 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <440e898334cae0debebd83d8cde70bbda150f2e9.1633092363.git.imeevma@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9064ADF4728AA0EE9B46A983E38D3F2FC9543D0F0079D7838182A05F53808504069D6A6EC5CD74F26DA12785F08CE7A5F31B729DB807D1AA7B2BA9606C3AB72AC X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70312E9A300D47E3BEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375C4806A08D329A618638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D81F5703B78BE74009C086CABEC17355D3117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCAA867293B0326636D2E47CDBA5A96583BD4B6F7A4D31EC0BC014FD901B82EE079FA2833FD35BB23D27C277FBC8AE2E8B2EE5AD8F952D28FBA471835C12D1D977C4224003CC8364762BB6847A3DEAEFB0F43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7C565C1E6824D8037B43847C11F186F3C59DAA53EE0834AAEE X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B505C0B97CAE4A76F82FB223DCFB60339075 X-C1DE0DAB: 0D63561A33F958A5E9C50D719DE3E0971EB4ACA270D862DF761498C41C6D9913D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7557E988E9157162368E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D3429538671E6527D32A9492CB7DDB2C3F61A1201B027AE6FC7BE292CDCBFAEAE72C8F453F5A1FF3B381D7E09C32AA3244C0F964AED4371BF9E6951C17577D444B7A995755A1445935E729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj+1ww+tpaZeoYIK43BMteqA== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D982B31514D2A22762FC7A99981EF091D3841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v4 12/16] sql: refactor MIN() and MAX() functions X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Good job on the fixes! > diff --git a/src/box/sql/vdbe.c b/src/box/sql/vdbe.c > index a3d403176..96eb76244 100644 > --- a/src/box/sql/vdbe.c > +++ b/src/box/sql/vdbe.c > @@ -4161,7 +4161,6 @@ case OP_AggStep: { > } > #endif > > - pMem->n++; Could you please remind me why is it dropped in this commit?