From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id A4681210DE for ; Tue, 11 Dec 2018 13:29:23 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 97hq6IfqLz57 for ; Tue, 11 Dec 2018 13:29:23 -0500 (EST) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 614F320C3D for ; Tue, 11 Dec 2018 13:29:21 -0500 (EST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.0 \(3445.100.39\)) Subject: [tarantool-patches] Re: [PATCH 2/6] sql: don't update SQL string during renaming From: "n.pettik" In-Reply-To: <02252f24-c2cb-d9f3-c327-48015855c1dc@tarantool.org> Date: Tue, 11 Dec 2018 21:29:19 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <4440A966-E81F-4F72-9091-C4160C033B7D@tarantool.org> References: <02252f24-c2cb-d9f3-c327-48015855c1dc@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: Vladislav Shpilevoy > On 10 Dec 2018, at 17:16, Vladislav Shpilevoy = wrote: >=20 > Thanks for the patch! >=20 > On 10/12/2018 00:30, Nikita Pettik wrote: >> Since SQL string containing "CREATE TABLE ..." statement is not used >> anymore for ordinary tables/space, it makes no sense to modify it = during >> renaming. Hence, now rename routine needs only to update name in = _space, >> so it can be done using simple update operation. >> Moreover, now we are able to rename spaces created from Lua-land. >> Part of #2647 >> --- >> src/box/sql.c | 187 = ++++++++------------------------------------ >> src/box/sql/tarantoolInt.h | 3 +- >> src/box/sql/vdbe.c | 4 +- >> test/sql-tap/alter.test.lua | 32 +++++++- >> 4 files changed, 63 insertions(+), 163 deletions(-) >=20 > You forgot to remove some code and comments. My > review fixes here and on the branch. Thx, applied.