From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 3A0AD2545C
	for <tarantool-patches@freelists.org>; Sat, 19 Jan 2019 19:19:39 -0500 (EST)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id vYoClkfccI1T for <tarantool-patches@freelists.org>;
	Sat, 19 Jan 2019 19:19:39 -0500 (EST)
Received: from smtp59.i.mail.ru (smtp59.i.mail.ru [217.69.128.39])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id E8B2124A9E
	for <tarantool-patches@freelists.org>; Sat, 19 Jan 2019 19:19:38 -0500 (EST)
Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\))
Subject: [tarantool-patches] Re: [PATCH v4 5/6] sql: 'PRAGMA' result in YAML
 format
From: "n.pettik" <korablev@tarantool.org>
In-Reply-To: <a3e6e457680e9aef5af78ca7a92f1572fcfbdef4.1547899933.git.imeevma@gmail.com>
Date: Sun, 20 Jan 2019 03:19:36 +0300
Content-Transfer-Encoding: 7bit
Message-Id: <4424957D-71D2-4C31-A288-42E22462055B@tarantool.org>
References: <cover.1547899933.git.imeevma@gmail.com>
 <a3e6e457680e9aef5af78ca7a92f1572fcfbdef4.1547899933.git.imeevma@gmail.com>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: Imeev Mergen <imeevma@tarantool.org>


> New version:
> 
> commit a3e6e457680e9aef5af78ca7a92f1572fcfbdef4
> Author: Mergen Imeev <imeevma@gmail.com>
> Date:   Thu Dec 13 21:07:31 2018 +0300
> 
>    sql: 'PRAGMA' result in YAML format

Commit's subject would look better with verb.

For instance:

sql: get results of PRAGMA statement in YAML format

Or sort of.

The rest is OK in this patch-set, so LGTM.