From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [94.100.177.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 7431946970E for ; Sat, 11 Jan 2020 10:03:34 +0300 (MSK) Received: by smtp47.i.mail.ru with esmtpa (envelope-from ) id 1iqAo2-0001Xt-1I for tarantool-patches@dev.tarantool.org; Sat, 11 Jan 2020 10:03:34 +0300 References: <20200110142749.11577-1-gorcunov@gmail.com> From: Oleg Babin Message-ID: <43fa7862-777b-1717-71e0-ccb8865d23e5@tarantool.org> Date: Sat, 11 Jan 2020 10:03:33 +0300 MIME-Version: 1.0 In-Reply-To: <20200110142749.11577-1-gorcunov@gmail.com> Content-Type: multipart/alternative; boundary="------------E52C77602B21CA1E6BC64E7A" Content-Language: en-GB Subject: Re: [Tarantool-patches] [PATCH] fiber: set diag error on madvise, mprotect fails List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: tarantool-patches@dev.tarantool.org This is a multi-part message in MIME format. --------------E52C77602B21CA1E6BC64E7A Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Hello, thanks for your patch! Our documentation doesn't contain any mentions that fiber.create can fail. Could you please file an issue (or may be doc bot request) with description in what cases user can expect that fiber.create will fail. Usually users don't use pcall for fiber.create and this fact can be quite unexpected for them. On 10/01/2020 17:27, Cyrill Gorcunov wrote: > Currently we use say_x to log if error happened. > Strictly speaking when madvise is used to relax > pressue on mm subsystem since we started to use > bigger stacks (due to libreadline increased memory > usage). > > Same time mprotect usage is more sensitive -- we > setup guard pages with its help and when failing > it is definitely an error which we should not only > mention in logger but provide a caller diag error. > Here is an example from memcached > -- Oleg Babin --------------E52C77602B21CA1E6BC64E7A Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit

Hello, thanks for your patch!

Our documentation doesn't contain any mentions that fiber.create can fail.

Could you please file an issue (or may be doc bot request) with description in what cases user

can expect that fiber.create will fail. Usually users don't use pcall for fiber.create and this fact can

be quite unexpected for them.


On 10/01/2020 17:27, Cyrill Gorcunov wrote:
Currently we use say_x to log if error happened.
Strictly speaking when madvise is used to relax
pressue on mm subsystem since we started to use
bigger stacks (due to libreadline increased memory
usage).

Same time mprotect usage is more sensitive -- we
setup guard pages with its help and when failing
it is definitely an error which we should not only
mention in logger but provide a caller diag error.
Here is an example from memcached

-- 
Oleg Babin

--------------E52C77602B21CA1E6BC64E7A--