From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 196942631E
	for <tarantool-patches@freelists.org>; Mon, 18 Feb 2019 07:14:35 -0500 (EST)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id uwLcacOF-L8m for <tarantool-patches@freelists.org>;
	Mon, 18 Feb 2019 07:14:35 -0500 (EST)
Received: from smtp58.i.mail.ru (smtp58.i.mail.ru [217.69.128.38])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 7AE5324BCA
	for <tarantool-patches@freelists.org>; Mon, 18 Feb 2019 07:14:34 -0500 (EST)
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\))
Subject: [tarantool-patches] Re: [PATCH v2 2/2] sql: rework "no such object"
 and "object exists" errors
From: "n.pettik" <korablev@tarantool.org>
In-Reply-To: <03c4d38a6b676a41d9b9cb094479c90d9a99c12d.1550250721.git.imeevma@gmail.com>
Date: Mon, 18 Feb 2019 15:14:30 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <43CF0F9C-EC0A-4C04-A60F-2103CBBE3CAA@tarantool.org>
References: <cover.1550250721.git.imeevma@gmail.com>
 <03c4d38a6b676a41d9b9cb094479c90d9a99c12d.1550250721.git.imeevma@gmail.com>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: Imeev Mergen <imeevma@tarantool.org>, Konstantin Osipov <kostja@tarantool.org>, Kirill Yukhin <kyukhin@tarantool.org>



> On 15 Feb 2019, at 20:14, imeevma@tarantool.org wrote:
>=20
> Hi! Thank you for review. My answers and new version below. There
> will not be diff between versions because the only meaningful fix
> was turned into new patch in the patch-set.

Ok, if Konstantin and you consider my comments as minor ones,
then I don=E2=80=99t mind if this part is pushed to 2.1 (Travis is OK, =
refactoring
is obvious).

Kirill, could you do this?