From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 1998B6EC57; Fri, 15 Oct 2021 01:43:57 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1998B6EC57 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1634251437; bh=7gaHsVK3EQ2N75F5S0anzjYVlptVSjXmBU1dgXti67c=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=D48bj19Kyy82/idPFUTV/byhDpNJgEiOviAzqizz2QL0s0rR3nLrawa0DKFdaAHsC U4syCPI7ycL5Q9jDFJnOaAAsvaplhavr1lVvGlOgNgfSgTXJ7HWn/mOmvdXipADvjQ SiAD5YcN+hBoBOhlGAcMz5LMWJBkWecHfBlAByjY= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E67A26E46D for ; Fri, 15 Oct 2021 01:43:34 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E67A26E46D Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1mb9Rm-0004dP-9v; Fri, 15 Oct 2021 01:43:34 +0300 Message-ID: <4308263e-95f4-9c97-f284-a4ff4136ec26@tarantool.org> Date: Fri, 15 Oct 2021 00:43:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 To: imeevma@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9AE9EF867AE584ADAC10ADC6D58547CF64A6290FE785EBC69182A05F538085040B107E8C4906C7E4E2DF216D5AF76238C4E29D1A04829A113AC1DF38BF399E716 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72F22E6DC541F75D9EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006375ABF1810CDE7D0E9EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BBCA57AF85F7723F23BD7FD3FB342A7FA1C6C64AF559A7CE0CC7F00164DA146DAFE8445B8C89999728AA50765F790063783E00425F71A4181389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8B861051D4BA689FCF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA7E827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8BDC0F6C5B2EEF3D0C75ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B50580647984BABFFB5262DE62E6FD8ED903 X-C1DE0DAB: 0D63561A33F958A5F798D7DB3ECF32D6D015B14FE484244975C310DE5CCA16D9D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7557E988E9157162368E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D349A949488F6BF46DDB688DA2E0052AA66A600830E0CB1B0FB6026C651D959240FA68B637E8957152F1D7E09C32AA3244CA3EFC3FDA77DB99359A5D8F193B9D54860759606DA2E136A729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojZCle+NCKLXHJaJsNJxHQ3g== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5DE5B95D26178E60969B535F7447F31B6E3841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 04/21] sql: refactor LENGTH() function X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the patch! On 08.10.2021 19:31, imeevma@tarantool.org wrote: > Part of #4145 > --- > src/box/sql/func.c | 55 +++++++++++++--------------------------------- > 1 file changed, 15 insertions(+), 40 deletions(-) > > diff --git a/src/box/sql/func.c b/src/box/sql/func.c > index e5d763be1..863dbf1c4 100644 > --- a/src/box/sql/func.c > +++ b/src/box/sql/func.c > @@ -833,6 +833,19 @@ func_hex(struct sql_context *ctx, int argc, struct Mem *argv) > mem_set_str_allocated(ctx->pOut, str, size); > } > > +/** Implementation of the OCTET_LENGTH() function. */ > +static void > +func_octet_length(struct sql_context *ctx, int argc, struct Mem *argv) Why is the function LENGTH defined as 'octet_length' instead of just 'length'?