From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id EC04C6EC58; Thu, 5 Aug 2021 01:27:52 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org EC04C6EC58 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1628116073; bh=/qtGA/ixf2V5OSvGpyxQR9870mzjZyLDnewMNfHos3A=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=j6eC6XojFO6twIDjCqCNw0f/mBwI11kbAGOi/x/smhs7e/SbfI3sDc2rQDWFAklqn Xrj9bo+XpLmT7Wou8E/8km75cxkvV2ZHU/7hlJ0XOCnU2gRhr/cdMZ3uzZraONk8Wo yJPgnOxMQeEOBzaI+TcL1GDDw8jqMLs5sMD5hkUg= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C2D5A6EC58 for ; Thu, 5 Aug 2021 01:27:42 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C2D5A6EC58 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1mBPMU-0007LC-4F; Thu, 05 Aug 2021 01:27:42 +0300 To: imeevma@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: <551fd439d751a10c19877016805811e826d28825.1627504973.git.imeevma@gmail.com> Message-ID: <42c5078b-fee5-3e7e-7680-b57597371107@tarantool.org> Date: Thu, 5 Aug 2021 00:27:41 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <551fd439d751a10c19877016805811e826d28825.1627504973.git.imeevma@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD941C43E597735A9C3104FC76DFAAAAF7DA068FE323FAC4379182A05F5380850402F55602EFB251D625CA2043BA7052B6816A850E8650E0FE0DF5905C9638E78FB X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70043D879A87EF1BCEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637E1D2769089B3DFB28638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8356F136035CF6EF573211F60499905D4117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCF1175FABE1C0F9B6A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD18F04B652EEC242312D2E47CDBA5A96583BA9C0B312567BB231DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6A45692FFBBD75A6A089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B50555CCE3650072E847AE085AB58E9A8EC0 X-C1DE0DAB: 0D63561A33F958A503518242E5EBD7CFEFD7F8F16DA4320CB856FCF56FA14E29D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7501A9DF589746230F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34C1D376EF32BB08962E5BFFFA175E8492BA8499E28491D4BF2AAECF93841C32EF9E3FBC444BEE7F211D7E09C32AA3244C86F46C277D97F1F792A19DA70608A21A35DA7DC5AF9B58C0729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojh4v93/7HD3VOSX8r+VUziA== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5D4DD89FE6DA86B8EA718501D028C318653841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 7/7] sql: remove unused MEM cast functions X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the patch! > diff --git a/src/box/sql/vdbeaux.c b/src/box/sql/vdbeaux.c > index 4a1fdb637..fc06e502e 100644 > --- a/src/box/sql/vdbeaux.c > +++ b/src/box/sql/vdbeaux.c > @@ -2323,17 +2323,15 @@ sqlVdbeDb(Vdbe * v) > * The returned value must be freed by the caller using sqlValueFree(). > */ > sql_value * > -sqlVdbeGetBoundValue(Vdbe * v, int iVar, u8 aff) > +sqlVdbeGetBoundValue(Vdbe * v, int iVar) 1. No need for a whitespace after *. > { > assert(iVar > 0); > if (v) { > Mem *pMem = &v->aVar[iVar - 1]; > if (!mem_is_null(pMem)) { > sql_value *pRet = sqlValueNew(v->db); > - if (pRet) { > + if (pRet) 2. != NULL.