From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 3309722236 for ; Wed, 27 Jun 2018 16:06:11 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8xOpFwOFixzD for ; Wed, 27 Jun 2018 16:06:11 -0400 (EDT) Received: from smtp17.mail.ru (smtp17.mail.ru [94.100.176.154]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id DC65521E17 for ; Wed, 27 Jun 2018 16:06:10 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH] sql: export `sql_current_time` && enable tests References: <20180516133341.21434-1-avkhatskevich@tarantool.org> <4AD7FCD7-67EB-4B16-BC6A-641FAE19E17E@tarantool.org> From: Alex Khatskevich Message-ID: <425ebcd7-9ec3-adaf-fc50-69a2a9c2b107@tarantool.org> Date: Wed, 27 Jun 2018 23:06:02 +0300 MIME-Version: 1.0 In-Reply-To: <4AD7FCD7-67EB-4B16-BC6A-641FAE19E17E@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: "n.pettik" , tarantool-patches@freelists.org On 26.06.2018 19:21, n.pettik wrote: >> -- Test cases table-14.* >> -- >> @@ -970,26 +944,6 @@ end >> -- But DROP TABLE is still prohibited because we do not want to >> -- delete a table out from under a running query. >> -- >> --- db eval { >> --- pragma vdbe_trace = 0; >> --- } >> --- Try to create a table from within a callback: >> --- ["unset","-nocomplain","result"] >> -test:do_test( >> - "table-14.1", >> - function() >> - local rc = pcall(function() >> - test:execsql("SELECT * FROM tablet8 LIMIT 1") >> - test:execsql("CREATE TABLE t9(a primary key, b, c)") >> - end) >> - rc = rc == true and 0 or 1 >> - return { rc } >> - end, { >> - -- >> - 0 >> - -- >> - }) >> - > Idk why did you delete this test within current patch? > > The rest seems to be OK. > As far as I remember, test was testing ddl inside of a running transaction in SQLite with the help of special TCL api. However, those lines do not test anything at all and there is a 14.2 test which does test this case. 1. I have added this text to the commit message. 2. I have rebased this branch on top of 2.0