From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp47.i.mail.ru (smtp47.i.mail.ru [94.100.177.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6BDEC469719 for ; Fri, 14 Feb 2020 01:50:19 +0300 (MSK) References: <9330b681273b2789ff147d5769736406695ca23a.1581625524.git.babinoleg@mail.ru> From: Vladislav Shpilevoy Message-ID: <422f9340-9acb-06bd-59de-270556a30cee@tarantool.org> Date: Thu, 13 Feb 2020 23:50:16 +0100 MIME-Version: 1.0 In-Reply-To: <9330b681273b2789ff147d5769736406695ca23a.1581625524.git.babinoleg@mail.ru> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH 3/3] tap: is_deeply ignores __pairs metamethod List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: olegrok@tarantool.org, tarantool-patches@dev.tarantool.org, imun@tarantool.org Cc: Oleg Babin Thanks for the patch! Comments are basically the same as for 2/3 patch about table.deepcopy: use imperative; rename to rawpairs; add commit title in () after commit hash; use 'Part of' for 4770, because it is not closed;