From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [94.100.177.108]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6FAC1469719 for ; Tue, 10 Nov 2020 11:07:23 +0300 (MSK) References: From: Serge Petrenko Message-ID: <422d8793-253e-2008-7d59-25dfd14c6432@tarantool.org> Date: Tue, 10 Nov 2020 11:07:22 +0300 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: 8bit Content-Language: en-GB Subject: Re: [Tarantool-patches] [PATCH v2 0/4] Raft module, part 1 - explicit argument List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy , tarantool-patches@dev.tarantool.org, gorcunov@gmail.com 10.11.2020 02:58, Vladislav Shpilevoy пишет: > The patchset is a first part of Raft movement to a separate library as > src/lib/raft. > > Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-5303-p1-raft-explicit-arg > Issue: https://github.com/tarantool/tarantool/issues/5303 > > Changes from v1: > - Renamed fiber.arg to fiber.f_arg; > - Stopped using memset for raft object creation; > - Raft global object access and validation is encapsulated into a > single function; > - Raft argument and runtime initialization commits are swapped. > > Vladislav Shpilevoy (4): > fiber: introduce fiber.f_arg > raft: add explicit raft argument to all functions > raft: check box_raft is inited before usage > vclock: move to src/lib Hi! Thanks for the patchset! LGTM. > > src/box/CMakeLists.txt | 3 - > src/box/alter.cc | 1 - > src/box/applier.cc | 6 +- > src/box/box.cc | 30 +- > src/box/error.cc | 2 +- > src/box/gc.c | 1 - > src/box/gc.h | 2 +- > src/box/lua/info.c | 9 +- > src/box/lua/init.c | 1 - > src/box/lua/space.cc | 2 +- > src/box/memtx_engine.c | 4 +- > src/box/raft.c | 631 ++++++++++++++++--------------- > src/box/raft.h | 72 ++-- > src/box/recovery.h | 2 +- > src/box/relay.cc | 2 +- > src/box/replication.cc | 1 - > src/box/replication.h | 2 +- > src/box/schema.cc | 2 +- > src/box/txn_limbo.h | 2 +- > src/box/vy_log.c | 2 +- > src/box/wal.c | 1 - > src/box/wal.h | 2 +- > src/box/xlog.h | 2 +- > src/box/xrow.c | 1 - > src/box/xrow.h | 2 +- > src/lib/CMakeLists.txt | 1 + > src/lib/core/fiber.h | 14 +- > src/lib/vclock/CMakeLists.txt | 6 + > src/{box => lib/vclock}/vclock.c | 0 > src/{box => lib/vclock}/vclock.h | 0 > test/unit/vclock.cc | 2 +- > 31 files changed, 437 insertions(+), 371 deletions(-) > create mode 100644 src/lib/vclock/CMakeLists.txt > rename src/{box => lib/vclock}/vclock.c (100%) > rename src/{box => lib/vclock}/vclock.h (100%) > -- Serge Petrenko