From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id AFF8B430407
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 17 Aug 2020 23:49:01 +0300 (MSK)
References: <20200814211442.667099-1-gorcunov@gmail.com>
 <20200814211442.667099-8-gorcunov@gmail.com>
 <af0743ac-3493-0c29-3380-21d41c6a8f1b@tarantool.org>
 <20200817124235.GJ2074@grain>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <41e3fd4b-6d04-a5ab-3a6c-858929456ee9@tarantool.org>
Date: Mon, 17 Aug 2020 22:49:00 +0200
MIME-Version: 1.0
In-Reply-To: <20200817124235.GJ2074@grain>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v7 7/8] applier: process synchro
 requests without txn engine
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>

On 17.08.2020 14:42, Cyrill Gorcunov wrote:
> On Sat, Aug 15, 2020 at 05:06:05PM +0200, Vladislav Shpilevoy wrote:
>>> +static struct synchro_entry *
>>> +synchro_entry_new(struct applier *applier,
>>> +		  struct xrow_header *applier_row,
>>> +		  struct synchro_request *req)
>>> +{
>>> +	struct synchro_entry *entry;
>>> +	size_t size = sizeof(*entry) + sizeof(struct xrow_header *);
>>
>> 6. Why don't you just add 'struct xrow_header*[1]' to the end of
>> struct synchro_entry? There is no a case, when the entry is needed
>> without the xrow_header pointer in the end.
> 
> This is forbidden by asan and some other compilers we've in travis runs.
> I've been already trying.

We use clang and gcc, just 2. To workaround that I suggest to add
-Wno-gnu-variable-sized-type-not-at-end to compiler.cmake (with that
flag it works, at least on clang - I need you to check it on gcc).