From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergepetrenko@tarantool.org>
Received: from smtp32.i.mail.ru (smtp32.i.mail.ru [94.100.177.92])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 0DF70469710
 for <tarantool-patches@dev.tarantool.org>;
 Thu,  7 May 2020 13:33:51 +0300 (MSK)
References: <20200420131115.42047-1-sergepetrenko@tarantool.org>
 <52ac079d-3439-a190-c418-52212a83683c@tarantool.org>
 <7cc455cc-185f-b4cb-17bb-13e3528c63c0@tarantool.org>
 <586c95c1-8bec-8205-402b-24c07ebf603d@tarantool.org>
From: Serge Petrenko <sergepetrenko@tarantool.org>
Message-ID: <41add5ba-4e48-0242-49bc-6db123466f4b@tarantool.org>
Date: Thu, 7 May 2020 13:33:50 +0300
MIME-Version: 1.0
In-Reply-To: <586c95c1-8bec-8205-402b-24c07ebf603d@tarantool.org>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: ru
Subject: Re: [Tarantool-patches] [PATCH] replication: remove unnecessary
 errors on replicating from an anonymous instance
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org


07.05.2020 00:51, Vladislav Shpilevoy пишет:
> Hi! Thanks for the fixes!


Thanks for the review!

> See 2 keyboard-related nits below. Everything else LGTM.
>
>> diff --git a/test/replication/anon.result b/test/replication/anon.result
>> index 997112c84..8782212ca 100644
>> --- a/test/replication/anon.result
>> +++ b/test/replication/anon.result
>> @@ -366,9 +367,9 @@ test_run:cmd('switch replica_anon2')
>>    | ---
>>    | - true
>>    | ...
>> -box.space.test:select{}
>> +test_run:wait_cond(function() return box.space.test:get{1} ~= nil  end, 10)
> 1. :) Double whitespace after '~= nil'.

Thanks =)

Fixed.

>>    | ---
>> - | - - [1]
>> + | - true
>>    | ...
>> @@ -429,36 +430,10 @@ test_run:cmd('set variable repl_source to "replica_anon1.listen"')
>>   box.cfg{replication=repl_source}
>>    | ---
>>    | ...
>> -
>> -test_run:cmd('switch default')
>> - | ---
>> - | - true
>> - | ...
>> -box.space.test:insert{2}
>> - | ---
>> - | - [2]
>> - | ...
>> -
>> -test_run:cmd('switch replica_anon1')
>> - | ---
>> - | - true
>> - | ...
>> --- Check that the new replica follows an anonymous one.
>> -test_run:wait_downstream(2, {status='follow'})
>> +test_run:wait_log('replica', 'ER_UNSUPPORTED: Anonymous replica does not support non.anonymous followers.', nil, 10)
> 2. Perhaps 'non-anonymous' instead of 'non.anonymous'?

Dot  matches anything, and I couldn't find a way to escape '-', it must 
be a special symbol of sorts.
So let it be 'non.anonymous'.

-- 
Serge Petrenko