From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lvasiliev@tarantool.org>
Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [217.69.128.41])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id BB8374765E0
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 25 Dec 2020 16:09:00 +0300 (MSK)
References: <cover.1608892639.git.void234@gmail.com>
From: Leonid Vasiliev <lvasiliev@tarantool.org>
Message-ID: <41a964bf-b635-6ea6-858f-9a634ee2210d@tarantool.org>
Date: Fri, 25 Dec 2020 16:08:54 +0300
MIME-Version: 1.0
In-Reply-To: <cover.1608892639.git.void234@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v5 0/2] base64: Fix decoder,
	improve its performance
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Nikiforov <void@tarantool.org>, tarantool-patches@dev.tarantool.org
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, Sergey Nikiforov <void234@gmail.com>

Hi!
The patchset LGTM.
I think it can be sent to A. Turenko to recive the second LGTM.

Add links to issue and branch.

On 25.12.2020 13:41, Sergey Nikiforov wrote:
> From: Sergey Nikiforov <void234@gmail.com>
> 
> First patch fixes #3069 and adds test for zero-sized output buffer,
> second one improves base64 decoder performance
> 
> Sergey Nikiforov (2):
>    base64: fix decoder output buffer overrun (reads)
>    base64: improve decoder performance
> 
>   test/unit/base64.c      | 13 +++++++++-
>   test/unit/base64.result |  3 ++-
>   third_party/base64.c    | 57 +++++++++++++++++++++++++++++------------
>   3 files changed, 54 insertions(+), 19 deletions(-)
>