From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp3.mail.ru (smtp3.mail.ru [94.100.179.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D372A4696C3 for ; Fri, 10 Apr 2020 15:27:54 +0300 (MSK) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) From: Serge Petrenko In-Reply-To: Date: Fri, 10 Apr 2020 15:27:53 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <418F6E76-2E6E-4441-9A60-6125DC9EFC9A@tarantool.org> References: Subject: Re: [Tarantool-patches] [PATCH v2 0/4] introduce indices over UUID List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org @ChangeLog - add ability to encode/decode uuids to MsgPack (#4268, #2916) - introduce field and index type UUID (#4268, #2916) -- Serge Petrenko sergepetrenko@tarantool.org > 10 =D0=B0=D0=BF=D1=80. 2020 =D0=B3., =D0=B2 02:50, Serge Petrenko = =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0= =B0): >=20 > https://github.com/tarantool/tarantool/issues/4268 > https://github.com/tarantool/tarantool/tree/sp/gh-4268-uuid-type >=20 > Changes in v2: > - disallow to insert strings and binstrings > to uuid fields. > - move mp_uuid files to uuid lib > - extract mpstream to a separate lib > - review fixes as per review from Vlad >=20 > Serge Petrenko (4): > refactoring: extract mpstream into a separate library > uuid: expose tt_uuid_validate method > box: add MsgPack encoding/decoding for UUID > box: introduce indices by UUID >=20 > extra/exports | 3 + > src/CMakeLists.txt | 2 +- > src/box/CMakeLists.txt | 2 +- > src/box/field_def.c | 32 +++++---- > src/box/field_def.h | 1 + > src/box/lua/call.c | 2 +- > src/box/lua/misc.cc | 2 +- > src/box/lua/net_box.c | 2 +- > src/box/lua/tuple.c | 2 +- > src/box/sql.c | 3 +- > src/box/sql/func.c | 2 +- > src/box/sql/vdbe.c | 2 +- > src/box/sql/vdbemem.c | 2 +- > src/box/tuple_compare.cc | 59 ++++++++++++++++ > src/box/xrow.c | 2 +- > src/lib/CMakeLists.txt | 1 + > src/lib/core/CMakeLists.txt | 1 - > src/lib/core/mp_extension_types.h | 2 + > src/lib/mpstream/CMakeLists.txt | 2 + > src/lib/{core =3D> mpstream}/mpstream.c | 13 +++- > src/lib/{core =3D> mpstream}/mpstream.h | 5 ++ > src/lib/msgpuck | 2 +- > src/lib/uuid/CMakeLists.txt | 2 +- > src/lib/uuid/mp_uuid.c | 98 +++++++++++++++++++++++++++ > src/lib/uuid/mp_uuid.h | 90 ++++++++++++++++++++++++ > src/lib/uuid/tt_uuid.c | 3 + > src/lib/uuid/tt_uuid.h | 16 +++-- > src/lua/msgpack.c | 29 ++++++-- > src/lua/msgpackffi.lua | 14 ++++ > src/lua/utils.c | 20 ++++++ > src/lua/utils.h | 5 ++ > src/lua/uuid.lua | 9 --- > test/app-tap/lua/serializer_test.lua | 8 +++ > test/app-tap/msgpackffi.test.lua | 3 +- > test/app/msgpack.result | 21 ++++++ > test/app/msgpack.test.lua | 13 ++++ > test/app/uuid.result | 13 +++- > test/app/uuid.test.lua | 5 ++ > test/box/tuple.result | 81 ++++++++++++++++++++++ > test/box/tuple.test.lua | 25 +++++++ > test/engine/ddl.result | 97 +++++++++++++++++++++++++- > test/engine/ddl.test.lua | 42 +++++++++++- > test/engine/uuid.result | 55 +++++++++++++++ > test/engine/uuid.test.lua | 27 ++++++++ > test/unit/uuid.c | 25 ++++++- > test/unit/uuid.result | 8 ++- > third_party/lua-cjson/lua_cjson.c | 27 +++++--- > third_party/lua-yaml/lyaml.cc | 17 ++++- > 48 files changed, 829 insertions(+), 68 deletions(-) > create mode 100644 src/lib/mpstream/CMakeLists.txt > rename src/lib/{core =3D> mpstream}/mpstream.c (95%) > rename src/lib/{core =3D> mpstream}/mpstream.h (97%) > create mode 100644 src/lib/uuid/mp_uuid.c > create mode 100644 src/lib/uuid/mp_uuid.h > create mode 100644 test/engine/uuid.result > create mode 100644 test/engine/uuid.test.lua >=20 > --=20 > 2.21.1 (Apple Git-122.3) >=20