From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp59.i.mail.ru (smtp59.i.mail.ru [217.69.128.39])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 056B64696C3
 for <tarantool-patches@dev.tarantool.org>;
 Sat, 21 Dec 2019 20:59:18 +0300 (MSK)
References: <cover.1576743850.git.imeevma@gmail.com>
 <7439b83392c9979f900966993ddaa2425a10b667.1576743850.git.imeevma@gmail.com>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <416ece86-4230-4639-c3d6-6430b8ece4c8@tarantool.org>
Date: Sat, 21 Dec 2019 18:59:17 +0100
MIME-Version: 1.0
In-Reply-To: <7439b83392c9979f900966993ddaa2425a10b667.1576743850.git.imeevma@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 1/3] box: introduce 'virtual' engine
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: imeevma@tarantool.org
Cc: tarantool-patches@dev.tarantool.org

Hi! Thanks for the patch!

I've pushed my review fixes on top of this commit. See it below
and on the branch. If you agree, then squash. Otherwise lets
discuss.

==================================================================

commit b3d8950d07a620ecbb19318495d33a59af5733b5
Author: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Date:   Sat Dec 21 18:02:43 2019 +0100

    Review fixes 1/3

diff --git a/src/box/virtual_engine.c b/src/box/virtual_engine.c
index 45993b91f..9a59a3f6a 100644
--- a/src/box/virtual_engine.c
+++ b/src/box/virtual_engine.c
@@ -30,7 +30,6 @@
  */
 #include "virtual_engine.h"
 #include "schema.h"
-#include "tuple.h"
 
 static void
 virtual_engine_shutdown(struct engine *engine)
diff --git a/src/box/virtual_engine.h b/src/box/virtual_engine.h
index 80ada450d..9cb5f520f 100644
--- a/src/box/virtual_engine.h
+++ b/src/box/virtual_engine.h
@@ -29,8 +29,6 @@
  * THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
  * SUCH DAMAGE.
  */
-#include <stddef.h>
-
 #if defined(__cplusplus)
 extern "C" {
 #endif /* defined(__cplusplus) */