From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Subject: Re: [tarantool-patches] Re: [PATCH 1/3] iproto: rename
 iproto_bind_msg to iproto_cfg_msg
References: <cover.1524264646.git.v.shpilevoy@tarantool.org>
 <12f30fd2d36b1af90047cc491c30fc18e149d8cf.1524264646.git.v.shpilevoy@tarantool.org>
 <20180423112202.jrqfczbsvfadw4ku@esperanza>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <4161e989-9462-ec56-742a-3483a0ce0323@tarantool.org>
Date: Mon, 23 Apr 2018 20:00:16 +0300
MIME-Version: 1.0
In-Reply-To: <20180423112202.jrqfczbsvfadw4ku@esperanza>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
To: Vladimir Davydov <vdavydov.dev@gmail.com>
Cc: tarantool-patches@freelists.org
List-ID: <tarantool-patches.dev.tarantool.org>

Hello. Thanks for review!

On 23/04/2018 14:22, Vladimir Davydov wrote:
> On Sat, Apr 21, 2018 at 01:52:09AM +0300, Vladislav Shpilevoy wrote:
>> IProto_bind_msg is used by TX thread to udpate bind address in
>> IProto thread with no explicit locking anything.
>>
>> In #3320 new IProto dynamic configuration parameter appears -
>> 'iproto_msg_max' which regulates how many IProto requests can be
>> in fly.
>>
>> The idea is to reuse iproto_bind_msg for this.
>>
>> Part of #3320
>> ---
>>   src/box/iproto.cc | 10 +++++-----
>>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> I don't see any point in this patch. Patch 3 overwrites half of it
> anyway so it doesn't really facilitate review. Please squash it.
> 

Done.