From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 1B92D29AEB
	for <tarantool-patches@freelists.org>; Fri, 17 Aug 2018 04:49:48 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id 3I_eD6pLlczy for <tarantool-patches@freelists.org>;
	Fri, 17 Aug 2018 04:49:48 -0400 (EDT)
Received: from smtp60.i.mail.ru (smtp60.i.mail.ru [217.69.128.40])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id D019A29AD4
	for <tarantool-patches@freelists.org>; Fri, 17 Aug 2018 04:49:47 -0400 (EDT)
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: [tarantool-patches] Re: [PATCH 2/2] sql: remove GLOB from Tarantool
From: "n.pettik" <korablev@tarantool.org>
In-Reply-To: <76466086-2a5f-8f12-cbc3-4ddf26e30fd9@tarantool.org>
Date: Fri, 17 Aug 2018 11:49:40 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <4137B8ED-FBEF-4B41-A84F-83AB8F75D0D6@tarantool.org>
References: <cover.1534436835.git.n.tatunov@tarantool.org>
 <4607dc428909e96915e9f0984a7733a0890a3185.1534436836.git.n.tatunov@tarantool.org>
 <76466086-2a5f-8f12-cbc3-4ddf26e30fd9@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: AKhatskevich <avkhatskevich@tarantool.org>, "N. Tatunov" <hollow653@gmail.com>, Alexander Turenko <alexander.turenko@tarantool.org>


> On 17 Aug 2018, at 11:25, Alex Khatskevich =
<avkhatskevich@tarantool.org> wrote:
>=20
> Do not split error messages at the middle of a sentence. It makes =
errors ungreppable.
> Make it <80 somehow different.

I guess this is extremely specific nitpicking: look at src/box/alter.cc:=20=

through the code there are a lot of breaks of error messages like:

alter.c : 405

tnt_raise(ClientError, errcode, tt_cstr(space_name, name_len),
         tt_sprintf("field %d has conflicting nullability and "
                   "nullable action properties", fieldno +
                   TUPLE_INDEX_BASE));

alter.cc : 524

if (exact_field_count !=3D 0 &&
    exact_field_count < field_count) {
       tnt_raise(ClientError, errcode, tt_cstr(name, name_len),
                "exact_field_count must be either 0 or >=3D "\
                "formatted field count=E2=80=9D);

etc