From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id D8CFA5E0A61; Thu, 14 Sep 2023 12:22:18 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org D8CFA5E0A61 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1694683339; bh=uddspxn9ZQaydJaCrL2q/+A9xZlLHOjb260deEfwWqI=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=YI9qrOyLtn9cPdyZW9ktZVrd5kw/poeOz8sifjDanrpzqbuBZbIy5Q7kF3cSTspOJ +bwIvTFt+9uaWvCK9MgBrnWbOFi92EGGRuZwPZL4EWY+g93CqkuKVZxAzGrVtwS96V /9LUHr1+aa6PM2ZTttEXt10iogWGdiNrlMfB43lA= Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [95.163.41.90]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id ED4A55A7C81 for ; Thu, 14 Sep 2023 12:22:16 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org ED4A55A7C81 Received: by smtp53.i.mail.ru with esmtpa (envelope-from ) id 1qgiYC-004kMg-0c; Thu, 14 Sep 2023 12:22:16 +0300 Message-ID: <410e5a92-cb69-7916-baaf-9a24aa0f998c@tarantool.org> Date: Thu, 14 Sep 2023 12:22:15 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Content-Language: en-US To: Maxim Kokryashkin References: <1b01124ea966b486d9462dea0d3653a45c4f81b1.1693481682.git.m.kokryashkin@tarantool.org> <1694549020.38036023@f474.i.mail.ru> In-Reply-To: <1694549020.38036023@f474.i.mail.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD927CFE6CA1630A10C1A6EB86C92C8A7C29A09A03CE3E311D400894C459B0CD1B9C251E8651B073BDF089669A073C54013C21D7E5C3A6EA8F477A82AC3F132B285 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE72F22E6DC541F75D9EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006370EBB47D88F71BB738638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D89B3E803FCDEB9B51501F1CE4B43FF716117882F4460429724CE54428C33FAD305F5C1EE8F4F765FCECADA55FE5B58BB7A471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F44604297287769387670735201E561CDFBCA1751FF04B652EEC242312D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE140C956E756FBB7A7C6FCE95544A9834D8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE364E7220B7C5505926E0066C2D8992A16C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637EB295DA9499754EBEFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5FE27B860681F4ADA35FB2D13BD15FAECE084E01C8DFB4349F87CCE6106E1FC07E67D4AC08A07B9B013BDA61BF53F5E1DCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFE9EC78BF2C53A35A27E60BA0786A106F51743A084C8336D0EBF15A36B6BA6E2896A3CD8EA40B8F97C4B8F2E8CFB8F5715F55CF2C2CF9CE3FC91DDB37001652ADA74DFFEFA5DC0E7F02C26D483E81D6BE0DBAE6F56676BC7117BB6831D7356A2DEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojoMTWofjSWSQAVwHe/TBGHg== X-Mailru-Sender: C4F68CFF4024C8867DFDF7C7F2588458DA46AAD2C7086D8F4301BD259F882E25E91E5C0C426EA6BC282EC151BADDC1D3523A6D01B4765B2DFB59E2DDD9FE06B14FA522850F29BC30B0DAF586E7D11B3E67EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v9 1/2] tools: add cli flag to run profile dump parsers X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: Maxim Kokryashkin , tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Max Thanks for the fixes! Two new comments: $  ./build/src/luajit -ts sysprof.bin ./build/src/luajit: ./tools/utils/symtab.lua:107: attempt to concatenate local 'magic' (a nil value) Please fix. $  ./build/src/luajit -ts mee ./build/src/luajit: ./tools/utils/bufread.lua:122: fopen, errno: 2 Seems the case is not handled in your code, let's fix it. On 9/12/23 23:03, Maxim Kokryashkin wrote: > Hi, Sergey! > Thanks for the review! > Fixed all of your comments, except for the one about > `luacheckrc` and _TARANTOOL. I believe, it should be > done in a separate patch. >