From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 1A646C631C5; Thu, 29 Aug 2024 12:46:03 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1A646C631C5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1724924763; bh=7jiJ6wt3JkslqGAGfaQUoR2X1Ken/BP8mWlrrap1tew=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=NQ/iV1X5b1M2k6Hvwbc83yw+Q0WVVkVYH8dpvtXJLhaGesF7wP/CFbuHt5XA9Ldmx MRWkjtWDykowK19MLvFo1vmWhz1VcWcpASOJHGvcQz2iSxcZ0K9A4Gc8eHNajKicyu 2lkwUfAqbOPRX05E/gMORuda+h7LnrNUOBveWsm0= Received: from smtp57.i.mail.ru (smtp57.i.mail.ru [95.163.41.95]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 08254C631C5 for ; Thu, 29 Aug 2024 12:46:02 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 08254C631C5 Received: by smtp57.i.mail.ru with esmtpa (envelope-from ) id 1sjbj6-00000003cMs-0clU; Thu, 29 Aug 2024 12:46:00 +0300 Content-Type: multipart/alternative; boundary="------------rG3M2vHvTITyBRsX02u0S2Ot" Message-ID: <40d21332-be24-4814-9510-32a29f2eaa9b@tarantool.org> Date: Thu, 29 Aug 2024 12:45:57 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun References: <439d9b017029c16d49cb9cf40dec881d6a9697b3.1724228998.git.skaplun@tarantool.org> <58df164b-ebe1-4ebb-80ba-f8606ea3a1d6@tarantool.org> In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD996C3684A4DDEC70E26DA70E810547F43F4D9E44BE457A497182A05F53808504064325C67A188C218A6D5EE0DB6E1EC8D39D1A1F6CBC8CBB54E2C8F2F5C7C6D3B87D23EDDC3F839DD X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE745229D52CF30560CEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378F586D843116CFB2EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38B043BF0FB74779F3660647D8E470E09B648BF701E1481517D4AEC24F8A0C60844A471835C12D1D9774AD6D5ED66289B5259CC434672EE6371117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE767883B903EA3BAEA9FA2833FD35BB23DF004C90652538430302FCEF25BFAB3454AD6D5ED66289B5278DA827A17800CE736256341E3452D54D32BA5DBAC0009BE395957E7521B51C2330BD67F2E7D9AF1090A508E0FED6299176DF2183F8FC7C084F21F0F3A33DEB2CD04E86FAF290E2DB606B96278B59C421DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B6ADE2ED557203A23075ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A560FC9F3A1597DD6A5002B1117B3ED696AED5D30C072D502C92212597CCBD6D77823CB91A9FED034534781492E4B8EEAD220496FFA5CD4785BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFDEE7BCBEA8867ADB2CAA387D7DC05B543C2F8256F885875C138A5241CD825CC166401EE05C14F77DF8F9848C95C03619237D9F91090B7874378044D1AB940ED58DA123A21F3787AE5F4332CA8FE04980913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj+zzg9FbUfZ+kOSpzyqyfQg== X-Mailru-Sender: C4F68CFF4024C8867DFDF7C7F2588458CD1BE24631ED7B5E5E07F309F87FFB1479B8666CE450F3F987F232CBA910A825645D15D82EE4B272BD6E4642A116CA93524AA66B5ACBE6721EF430B9A63E2A504198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 31/45] test: refactor LuaJIT test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------rG3M2vHvTITyBRsX02u0S2Ot Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, Sergey, On 26.08.2024 09:56, Sergey Kaplun wrote: >> thanks for the patch! LGTM with a minor: >> >> probably line 10 needs more whitespaces: >> >> >      do local a,b,c,d,e,f,g,h,i,j,k,l,m,n end -- Ensure bigger frame >> size. > Fixed thanks! > See the iterative patch below. > > =================================================================== > diff --git a/test/LuaJIT-tests/lang/gc_stack.lua b/test/LuaJIT-tests/lang/gc_stack.lua > index 8aee57e3..d05d4402 100644 > --- a/test/LuaJIT-tests/lang/gc_stack.lua > +++ b/test/LuaJIT-tests/lang/gc_stack.lua > @@ -7,7 +7,10 @@ do --- Marking sparse stack. > else > return t[k] -- Leaves holes in each frame. > end > - do local a,b,c,d,e,f,g,h,i,j,k,l,m,n end -- Ensure bigger frame size. > + do > + -- Ensure bigger frame size. > + local a, b, c, d, e, f, g, h, i, j, k, l, m, n > + end > end}) > local x = t[50] > end > =================================================================== > Thanks! LGTM --------------rG3M2vHvTITyBRsX02u0S2Ot Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hi, Sergey,

On 26.08.2024 09:56, Sergey Kaplun wrote:


<snipped>

thanks for the patch! LGTM with a minor:

probably line 10 needs more whitespaces:

 >      do local a,b,c,d,e,f,g,h,i,j,k,l,m,n end -- Ensure bigger frame 
size.

Fixed thanks!
See the iterative patch below.

===================================================================
diff --git a/test/LuaJIT-tests/lang/gc_stack.lua b/test/LuaJIT-tests/lang/gc_stack.lua
index 8aee57e3..d05d4402 100644
--- a/test/LuaJIT-tests/lang/gc_stack.lua
+++ b/test/LuaJIT-tests/lang/gc_stack.lua
@@ -7,7 +7,10 @@ do --- Marking sparse stack.
     else
       return t[k] -- Leaves holes in each frame.
     end
-    do local a,b,c,d,e,f,g,h,i,j,k,l,m,n end -- Ensure bigger frame size.
+    do
+      -- Ensure bigger frame size.
+      local a, b, c, d, e, f, g, h, i, j, k, l, m, n
+    end
   end})
   local x = t[50]
 end
===================================================================
Thanks! LGTM

      

    

    <snipped>

  
  


--------------rG3M2vHvTITyBRsX02u0S2Ot--