From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 339EE15D1133; Mon, 17 Nov 2025 17:15:16 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 339EE15D1133 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1763388916; bh=7KsfSBdhlu8gw3cbs1qFMklJ2bPEacwugcecAPFzpIM=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=Rry8vpG5nap1fjepDSS6EmZvWdwNXKbjbDsbwb+trSYv0onyJebROpFp1kjO2jOFI t8Kqbd8F9WqpjXh78CEJrHPYwM2Bw9o+j/yzmLb2VIxVcYyb0nNqr2isqtWqgTJJEK 32BcVrKZqVKNMxf42FInykftLig6gxiKaqqeH0WQ= Received: from send149.i.mail.ru (send149.i.mail.ru [89.221.237.244]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A99EC15D1128 for ; Mon, 17 Nov 2025 17:15:15 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A99EC15D1128 Received: by exim-smtp-88cf54d45-9757f with esmtpa (envelope-from ) id 1vL00g-000000001Kf-35mI; Mon, 17 Nov 2025 17:15:15 +0300 Content-Type: multipart/alternative; boundary="------------wKLvkHTq20EQrmhQ8dZf9v6e" Message-ID: <40c8db73-e9af-4e73-9561-9e62e29188e3@tarantool.org> Date: Mon, 17 Nov 2025 17:15:14 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9110BAFCBE6BD1D167AB5004BEA225D964407BC14E2B63626182A05F5380850407DCB5951FD9741223DE06ABAFEAF67058AF8B33AB2D811C561C9E0771A6A769CA9248E35AFBCB78E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F87C043BA75DB4CEEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637B5932F77F0041FFB8638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B212C718FEB6E0212D2E070BE324C7D3C4DBDEA7030D434C39F6B57BC7E64490618DEB871D839B73339E8FC8737B5C2249957A4DEDD2346B42CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C0ECC8AC47CD0EDEFF8941B15DA834481F9449624AB7ADAF37BA3038C0950A5D3613377AFFFEAFD269176DF2183F8FC7C0FEA73F50E9734B707B076A6E789B0E97A8DF7F3B2552694AD5FFEEA1DED7F25D49FD398EE364050F9647ADFADE5905B1FCB1554B277F7060B3661434B16C20ACC84D3B47A649675FE827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B569F1129A2C6445075ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A50F3A261B074518035002B1117B3ED6967B51EAD6086EEA07A13BD6A4B0E00B96823CB91A9FED034534781492E4B8EEADA3A806F356AF31D6 X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D349FD10E01B3CDC9E2AD74C6408C88F5B3A97EDC1BE7140375A83F994E86E3671641D1C8714858AD601D7E09C32AA3244CF2BE525BDF5571A877DD89D51EBB77424498F81A5639E956EA455F16B58544A2E30DDF7C44BCB90DA5AE236DF995FB59978A700BF655EAEEED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVfFX+FmbwDW1tE087xMY1fs= X-Mailru-Sender: 520A125C2F17F0B1A9638AD358559B59DE0471203A4CD33F3DE06ABAFEAF67058AF8B33AB2D811C5B7CBEF92542CD7C8795FA72BAB74744FC77752E0C033A69EA16A481184E8BB1C9B38E6EA4F046BE03A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 luajit 33/41] perf: adjust scimark-sparse in LuaJIT-benches X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------wKLvkHTq20EQrmhQ8dZf9v6e Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey, thanks for the patch! LGTM with a minor comment. please add a small test description to the comment. Sergey On 10/24/25 13:50, Sergey Kaplun wrote: > This patch adjusts the aforementioned test to use the benchmark > framework introduced before. The default arguments are adjusted > according to the file. The arguments to the script still > can be provided in the command line run. > > Checks are omitted since they were not present in the original suite, > plus the precise result value depends on the input parameter. > --- > perf/LuaJIT-benches/scimark-sparse.lua | 20 +++++++++++++++++++- > 1 file changed, 19 insertions(+), 1 deletion(-) > > diff --git a/perf/LuaJIT-benches/scimark-sparse.lua b/perf/LuaJIT-benches/scimark-sparse.lua > index 01a2258d..a855cc22 100644 > --- a/perf/LuaJIT-benches/scimark-sparse.lua > +++ b/perf/LuaJIT-benches/scimark-sparse.lua > @@ -1 +1,19 @@ > -require("scimark_lib").SPARSE(1000, 5000)(tonumber(arg and arg[1]) or 150000) > +local bench = require("bench").new(arg) > + > +local cycles = tonumber(arg and arg[1]) or 150000 > + > +local benchmark > +benchmark = { > + name = "scimark_sparse", > + -- XXX: The description of tests for the function is too > + -- inconvenient. > + skip_check = true, > + payload = function() > + local flops = require("scimark_lib").SPARSE(1000, 5000)(cycles) > + benchmark.items = flops > + end, > +} > + > +bench:add(benchmark) > + > +bench:run_and_report() --------------wKLvkHTq20EQrmhQ8dZf9v6e Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey,

thanks for the patch! LGTM with a minor comment.

please add a small test description to the comment.

Sergey

On 10/24/25 13:50, Sergey Kaplun wrote:
This patch adjusts the aforementioned test to use the benchmark
framework introduced before. The default arguments are adjusted
according to the <PARAM_x86.txt> file. The arguments to the script still
can be provided in the command line run.

Checks are omitted since they were not present in the original suite,
plus the precise result value depends on the input parameter.
---
 perf/LuaJIT-benches/scimark-sparse.lua | 20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)

diff --git a/perf/LuaJIT-benches/scimark-sparse.lua b/perf/LuaJIT-benches/scimark-sparse.lua
index 01a2258d..a855cc22 100644
--- a/perf/LuaJIT-benches/scimark-sparse.lua
+++ b/perf/LuaJIT-benches/scimark-sparse.lua
@@ -1 +1,19 @@
-require("scimark_lib").SPARSE(1000, 5000)(tonumber(arg and arg[1]) or 150000)
+local bench = require("bench").new(arg)
+
+local cycles = tonumber(arg and arg[1]) or 150000
+
+local benchmark
+benchmark = {
+  name = "scimark_sparse",
+  -- XXX: The description of tests for the function is too
+  -- inconvenient.
+  skip_check = true,
+  payload = function()
+    local flops = require("scimark_lib").SPARSE(1000, 5000)(cycles)
+    benchmark.items = flops
+  end,
+}
+
+bench:add(benchmark)
+
+bench:run_and_report()
--------------wKLvkHTq20EQrmhQ8dZf9v6e--